You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Yang Wang (Jira)" <ji...@apache.org> on 2020/12/23 02:48:00 UTC
[jira] [Commented] (FLINK-20650) Mark "native-k8s" as deprecated in
docker-entrypoint.sh
[ https://issues.apache.org/jira/browse/FLINK-20650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253852#comment-17253852 ]
Yang Wang commented on FLINK-20650:
-----------------------------------
Since we are keeping the {{native-k8s}} command in whole 1.12 release versions, the Flink project related changes do not need to be merged into branch 1.12. It is just need to be merged to master branch. This could keep a good compatibility for the following cases.
* Flink client with 1.12.0 and docker image with Flink 1.12.1+
* Flink client with 1.12.1+ and docker image with Flink 1.12.0
> Mark "native-k8s" as deprecated in docker-entrypoint.sh
> -------------------------------------------------------
>
> Key: FLINK-20650
> URL: https://issues.apache.org/jira/browse/FLINK-20650
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / Kubernetes, flink-docker
> Affects Versions: 1.12.0
> Reporter: Yang Wang
> Assignee: Yang Wang
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.13.0, 1.12.1
>
>
> When we are publishing the image 1.12 to docker hub, some docker guys raise up a issue for the {{docker-entrypoint.sh}}. They want the images to have a certain standard, because they are the official ones. However the proposed {{native-k8s}} command is more like an internal bridge. It is only used for native Kubernetes integration.
>
> Another suggestion is removing the "bash -c" wrapper and generate it in the flink codes. Refer here[1] for more information.
>
> Note: when we rename the {{native-k8s}} to {{generic}} in the flink-docker project, the flink Kubernetes codes should be adjusted accordingly.
>
> [1]. https://github.com/docker-library/official-images/pull/9249
--
This message was sent by Atlassian Jira
(v8.3.4#803005)