You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kevingurney (via GitHub)" <gi...@apache.org> on 2023/05/08 19:45:15 UTC
[GitHub] [arrow] kevingurney opened a new pull request, #35493: [MATLAB] Add CMake build folder to MATLAB `.gitignore`
kevingurney opened a new pull request, #35493:
URL: https://github.com/apache/arrow/pull/35493
### Rationale for this change
A typical name that is used for the build folder when building CMake projects is `build`.
The documentation for building the MATLAB interface [mentions using `build` as the build directory name](https://github.com/apache/arrow/tree/main/matlab#build). It would be helpful if `build/` was added to the MATLAB interface `.gitignore` so that the build directory doesn't show up in the list of untracked files with `git`.
### What changes are included in this PR?
Added `build` to the MATLAB `.gitignore`.
### Are these changes tested?
Manually verified on Debian 11 that the `build` folder doesn't show up as untracked with `git`.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35493: [MATLAB] Add CMake build folder to MATLAB `.gitignore`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35493:
URL: https://github.com/apache/arrow/pull/35493#issuecomment-1538945939
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35493: GH-35489: [MATLAB] Add CMake `build` directory to MATLAB `.gitignore`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35493:
URL: https://github.com/apache/arrow/pull/35493#issuecomment-1540037726
Benchmark runs are scheduled for baseline = 5b8eb64780c9c017c4375fcf94bf009e978bf087 and contender = ad43544e5645dd70c9bde11fa9b1988040446db5. ad43544e5645dd70c9bde11fa9b1988040446db5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f1a31f17543f4f8cbd7b0a267827bac4...dfa994b923ec491092090a98ad126ebc/)
[Failed :arrow_down:2.22% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/002fcb87fd33419d8aee6e2c7b326857...5fba208941c84849801fbeaa4ea58298/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9a0dfd17457741f4855a69a35b83d920...8f0f1996891f4dd3812d84f56baec76a/)
[Failed :arrow_down:2.86% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9b413edfa99d4d7ea18535567d1ee662...92f36c0ae1e5409cb34757d280301eed/)
Buildkite builds:
[Finished] [`ad43544e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2832)
[Failed] [`ad43544e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2869)
[Finished] [`ad43544e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2832)
[Failed] [`ad43544e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2859)
[Finished] [`5b8eb647` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2831)
[Failed] [`5b8eb647` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2868)
[Finished] [`5b8eb647` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2831)
[Failed] [`5b8eb647` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2858)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35493: GH-35489: [MATLAB] Add CMake `build` directory to MATLAB `.gitignore`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35493:
URL: https://github.com/apache/arrow/pull/35493#issuecomment-1540038124
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/002fcb87fd33419d8aee6e2c7b326857...5fba208941c84849801fbeaa4ea58298/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35493: GH-35489: [MATLAB] Add `build` directory to MATLAB `.gitignore`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35493:
URL: https://github.com/apache/arrow/pull/35493#issuecomment-1538947323
* Closes: #35489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35493: GH-35489: [MATLAB] Add CMake `build` directory to MATLAB `.gitignore`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35493:
URL: https://github.com/apache/arrow/pull/35493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org