You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/15 09:32:09 UTC
[GitHub] [lucenenet] NightOwl888 opened a new issue, #659: All DefaultSetHolder classes (in Analyzers) should be marked static
NightOwl888 opened a new issue, #659:
URL: https://github.com/apache/lucenenet/issues/659
This was picked up by SonarCloud
https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=nikcio_lucenenet&open=AYPAuPhThbfJOGLOobIl
While these were marked `static` in Lucene, the `static` keyword has a different meaning in Java (basically, it just means "nested" and you can still instantiate them). However, since there are no members that are non-static, adding this keyword in .NET is appropriate and recommended.
There are a few dozen of these classes in analyzers which should all be consistently named (some of which may not be in `Lucene.Net,Analysis.Common`), so this is a straightforward fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] nikcio commented on issue #659: All DefaultSetHolder classes (in Analyzers) should be marked static
Posted by GitBox <gi...@apache.org>.
nikcio commented on issue #659:
URL: https://github.com/apache/lucenenet/issues/659#issuecomment-1279738157
Similar issues can be seen under: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1118&id=nikcio_lucenenet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 closed issue #659: All DefaultSetHolder classes (in Analyzers) should be marked static
Posted by GitBox <gi...@apache.org>.
NightOwl888 closed issue #659: All DefaultSetHolder classes (in Analyzers) should be marked static
URL: https://github.com/apache/lucenenet/issues/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org