You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by lizhanhui <gi...@git.apache.org> on 2017/05/18 05:16:25 UTC
[GitHub] incubator-rocketmq pull request #106: [ROCKETMQ-202] Using the native transp...
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/106
[ROCKETMQ-202] Using the native transport
Since 4.0.16, Netty provides the native socket transport for Linux using JNI. This transport has higher performance and produces less garbage, so you might want to give it a try.
See [Netty native transportation docs](http://netty.io/wiki/native-transports.html)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-202
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit fccc2d3f0d38fa40e863a56442dbe10ee91b7ac5
Author: Li Zhanhui <li...@apache.org>
Date: 2017-05-18T05:12:56Z
Using the native transport
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by lindzh <gi...@git.apache.org>.
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
Is there any performance data when change to Epoll?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
[](https://coveralls.io/builds/11577835)
Coverage increased (+0.05%) to 37.93% when pulling **fccc2d3f0d38fa40e863a56442dbe10ee91b7ac5 on lizhanhui:ROCKETMQ-202** into **1630f277b9c9f8e85c9bdb09a323d39e13e797e4 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
[](https://coveralls.io/builds/11781278)
Coverage increased (+0.009%) to 38.671% when pulling **5f80d7ea9a97f36315ec29d0971a5f6350122526 on lizhanhui:ROCKETMQ-202** into **0fe947173a85d8931b1068805713e89dbba4125a on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
@lizhanhui Looks good. Can we have some tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
@shroman What kind of tests, in you mind, should we have for this PR? Benchmark tests to profile performances between java NIO transport and native transport?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
@lizhanhui I was thinking about platform dependent tests, but performance profiling would be nice too. Sorry for being vague.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
@lindzh Checkout this lecture presented by author of Netty, https://www.youtube.com/watch?v=DKJ0w30M0vg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
[](https://coveralls.io/builds/11617091)
Coverage increased (+0.02%) to 37.903% when pulling **a5be3b30b58196fba8ee7dc6979a8deb27801b0a on lizhanhui:ROCKETMQ-202** into **1630f277b9c9f8e85c9bdb09a323d39e13e797e4 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #106: [ROCKETMQ-202] Using the native transport
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/106
@shroman @Jaskey @dongeforever @zhouxinyu Guys, please review this minor improvement pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---