You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/04 07:14:15 UTC

[GitHub] [skywalking] wu-sheng opened a new pull request #4311: Provide the new version upgrade documentation/FAQ.

wu-sheng opened a new pull request #4311: Provide the new version upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311
 
 
   As many people asked, I finally have time to write this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4311: Provide the new version upgrade documentation/FAQ.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4311: Provide the new version upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#issuecomment-581785570
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=h1) Report
   > Merging [#4311](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ef60cb27813a02c8cd374b167a542c3a60102393?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4311/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4311      +/-   ##
   ==========================================
   + Coverage    26.8%   26.83%   +0.02%     
   ==========================================
     Files        1170     1170              
     Lines       25479    25479              
     Branches     3627     3627              
   ==========================================
   + Hits         6830     6837       +7     
   + Misses      18046    18041       -5     
   + Partials      603      601       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `70.51% <0%> (+1.28%)` | :arrow_up: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `64.6% <0%> (+3.53%)` | :arrow_up: |
   | [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `87.5% <0%> (+6.25%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=footer). Last update [ef60cb2...e100194](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4311: Provide the new version upgrade documentation/FAQ.

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4311: Provide the new version upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4311: Provide the new version upgrade documentation/FAQ.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4311: Provide the new version upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#discussion_r374522203
 
 

 ##########
 File path: docs/en/FAQ/v6-version-upgrade.md
 ##########
 @@ -0,0 +1,30 @@
+# V6 upgrade
+SkyWalking v6 is widely used in many production environments. Users may wants to upgrade to an old release to new.
+This is a guidance to tell users how to do that.
+
+**NOTICE**, the following ways are not the only ways to do upgrade.
+
+## Use Canary Release
+Like all applications, SkyWalking could use `canary release` method to upgrade by following these steps
+1. Deploy a new cluster by using the latest(or new) version of SkyWalking OAP cluster with new database cluster.
+1. Once the target(being monitored) service has chance to upgrade the agent.jar(or just simply reboot), change the `collector.backend_service`
+pointing to the new OAP backend, and use/add a new namespace(`agent.namespace` in [Table of Agent Configuration Properties](../setup/service-agent/java-agent/README.md#table-of-agent-configuration-properties)).
+The namespace will avoid the conflict between different versions.
+1. When all target services have been rebooted, the old OAP clusters could be discarded.
+
+`Canary Release` methods works for any version upgrade.
+
+## Online Hot Reboot Upgrade
+The reason we required `Canary Release` is, SkyWalking agent has cache mechanisms, switching to a new cluster makes the 
+cache unavailable for new OAP cluster.
+In the 6.5.0+(especially for agent version), we have [**Agent hot reboot trigger mechanism**](../setup/backend/backend-setup.md#agent-hot-reboot-trigger-mechanism-in-oap-server-upgrade).
+By using that, we could do upgrade an easier way, **deploy a new cluster by using the latest(or new) version of SkyWalking OAP cluster with new database cluster**,
+and shift the traffic to the new cluster once for all. Based on the mechanism, all agents will go into `cool_down` mode, then
+back online. More detail, read the backend setup document.
+
+**NOTICE**, as a known bug in 6.4.0, its agent could have re-connection issue, so, even this bot reboot mechanism included in 6.4.0,
+it may not work in some network scenarios, especially in k8s.
+
+## Agent Compatibility
+All versions of SkyWalking 6.x(even 7.x) are compatible with each others, so users could not upgrade the agents. 
 
 Review comment:
   `Users could not upgrade the agents even they upgraded the OAP server.` I will make the sentence more clear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4311: Provide the new version upgrade documentation/FAQ.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4311: Provide the new version upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#issuecomment-581785570
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=h1) Report
   > Merging [#4311](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/68eb14a93459b52484a4182301e40922d278dc33?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4311/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #4311   +/-   ##
   =======================================
     Coverage   26.81%   26.81%           
   =======================================
     Files        1170     1170           
     Lines       25479    25479           
     Branches     3627     3627           
   =======================================
     Hits         6831     6831           
     Misses      18046    18046           
     Partials      602      602
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=footer). Last update [68eb14a...70fdc0d](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4311: Provide the new version upgrade documentation/FAQ.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4311: Provide the new version upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#discussion_r374521678
 
 

 ##########
 File path: docs/en/FAQ/v6-version-upgrade.md
 ##########
 @@ -0,0 +1,30 @@
+# V6 upgrade
+SkyWalking v6 is widely used in many production environments. Users may wants to upgrade to an old release to new.
+This is a guidance to tell users how to do that.
+
+**NOTICE**, the following ways are not the only ways to do upgrade.
+
+## Use Canary Release
+Like all applications, SkyWalking could use `canary release` method to upgrade by following these steps
+1. Deploy a new cluster by using the latest(or new) version of SkyWalking OAP cluster with new database cluster.
+1. Once the target(being monitored) service has chance to upgrade the agent.jar(or just simply reboot), change the `collector.backend_service`
+pointing to the new OAP backend, and use/add a new namespace(`agent.namespace` in [Table of Agent Configuration Properties](../setup/service-agent/java-agent/README.md#table-of-agent-configuration-properties)).
+The namespace will avoid the conflict between different versions.
+1. When all target services have been rebooted, the old OAP clusters could be discarded.
+
+`Canary Release` methods works for any version upgrade.
+
+## Online Hot Reboot Upgrade
+The reason we required `Canary Release` is, SkyWalking agent has cache mechanisms, switching to a new cluster makes the 
+cache unavailable for new OAP cluster.
+In the 6.5.0+(especially for agent version), we have [**Agent hot reboot trigger mechanism**](../setup/backend/backend-setup.md#agent-hot-reboot-trigger-mechanism-in-oap-server-upgrade).
+By using that, we could do upgrade an easier way, **deploy a new cluster by using the latest(or new) version of SkyWalking OAP cluster with new database cluster**,
+and shift the traffic to the new cluster once for all. Based on the mechanism, all agents will go into `cool_down` mode, then
+back online. More detail, read the backend setup document.
+
+**NOTICE**, as a known bug in 6.4.0, its agent could have re-connection issue, so, even this bot reboot mechanism included in 6.4.0,
+it may not work in some network scenarios, especially in k8s.
+
+## Agent Compatibility
+All versions of SkyWalking 6.x(even 7.x) are compatible with each others, so users could not upgrade the agents. 
 
 Review comment:
   "compatible", "so users could not upgrade the agents." ? typo?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4311: Provide the new version upgrade documentation/FAQ.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4311: Provide the new version upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#issuecomment-581785570
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=h1) Report
   > Merging [#4311](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/68eb14a93459b52484a4182301e40922d278dc33?src=pr&el=desc) will **increase** coverage by `0.29%`.
   > The diff coverage is `81.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4311/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #4311      +/-   ##
   =========================================
   + Coverage   26.81%   27.1%   +0.29%     
   =========================================
     Files        1170    1174       +4     
     Lines       25479   25606     +127     
     Branches     3627    3645      +18     
   =========================================
   + Hits         6831    6941     +110     
   - Misses      18046   18059      +13     
   - Partials      602     606       +4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../core/profile/analyze/ProfileAnalyzeCollector.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplQ29sbGVjdG9yLmphdmE=) | `100% <100%> (ø)` | |
   | [...p/server/core/profile/analyze/ProfileAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplci5qYXZh) | `77.77% <77.77%> (ø)` | |
   | [.../oap/server/core/profile/analyze/ProfileStack.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFjay5qYXZh) | `8.33% <8.33%> (ø)` | |
   | [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `90.09% <90.09%> (ø)` | |
   | [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `70.51% <0%> (+1.28%)` | :arrow_up: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `64.6% <0%> (+2.65%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/4311/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=footer). Last update [68eb14a...70fdc0d](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services