You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/29 07:54:08 UTC
[GitHub] [skywalking-rocketbot-ui] xuchangjunjx opened a new pull request #405: optimize rk-icon
xuchangjunjx opened a new pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405
1. fix the rk-footer utc input's width too small
2. replace svg tag with rk-icon in component rk-header
3. update component rk-icon.vue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] xuchangjunjx commented on pull request #405: optimize rk-icon
Posted by GitBox <gi...@apache.org>.
xuchangjunjx commented on pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405#issuecomment-752005739
> Could you provide screenshot or gif to show what do you fix?
The Old:
<img width="1755" alt="old" src="https://user-images.githubusercontent.com/9313869/103272546-1f40f580-49f8-11eb-9be8-635e7ac9843c.png">
The new:
className `vm` just set `vertical-align: middle;` , and className `icon` has included
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #405: optimize rk-icon
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405#issuecomment-752299507
Clone apache/skywalking and update the UI submodule. It uses git submodule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #405: optimize rk-icon
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405#issuecomment-752006853
@Fine0830 Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #405: optimize rk-icon
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405#issuecomment-752127459
@xuchangjunjx Could you submit a pull request to sync the main repo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #405: optimize rk-icon
Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #405: optimize rk-icon
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405#issuecomment-751988422
Could you provide screenshot or gif to show what do you fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] xuchangjunjx commented on pull request #405: optimize rk-icon
Posted by GitBox <gi...@apache.org>.
xuchangjunjx commented on pull request #405:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/405#issuecomment-752299214
> @xuchangjunjx Could you submit a pull request to sync the main repo?
合到075b29fce4上吗还是直接clone @apache/skywalking ? 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org