[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #5221: Prevent usage of @Test(expected = ...) and change existing tests

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #5221:
URL: https://github.com/apache/iceberg/pull/5221#discussion_r918276183


##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -410,6 +410,11 @@
             <property name="format" value="(void setUp\(\))|(void setup\(\))|(void setupStatic\(\))|(void setUpStatic\(\))|(void beforeTest\(\))|(void teardown\(\))|(void tearDown\(\))|(void beforeStatic\(\))|(void afterStatic\(\))"/>
             <property name="message" value="Test setup/teardown methods are called before(), beforeClass(), after(), afterClass(), but not setUp, teardown, etc."/>
         </module>
+        <module name="RegexpSinglelineJava">
+            <property name="ignoreComments" value="true"/>
+            <property name="format" value="@Test\(.*expected.*\)"/>
+            <property name="message" value="Prefer using Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/>

Review Comment:
   We actually have a helper for this in AssertHelpers
   
   ```  /**
      * A convenience method to avoid a large number of @Test(expected=...) tests
      * @param message A String message to describe this assertion
      * @param expected An Exception class that the Runnable should throw
      * @param containedInMessage A String that should be contained by the thrown
      *                           exception's message
      * @param runnable A Runnable that is expected to throw the runtime exception
      */
     public static void assertThrows(String message,
                                     Class<? extends Exception> expected,
                                     String containedInMessage,
                                     Runnable runnable) {
   ```java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org