You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2026/09/11 09:05:02 UTC

(shardingsphere) branch master updated: For code format (#39802)

This is an automated email from the ASF dual-hosted git repository.

terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 54be0ad8211 For code format (#39802)
54be0ad8211 is described below

commit 54be0ad82111b9d584895feb5684e772dd181931
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Fri Sep 11 17:04:55 2026 +0800

    For code format (#39802)
    
    * Refactor CreateViewPushDownMetaDataRefresherTest
    
    * For code format
---
 .../AbstractDelegatingDialectDatabaseMetaData.java         | 14 +++-----------
 .../test/e2e/env/container/util/SQLScriptUtils.java        |  6 +-----
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/metadata/AbstractDelegatingDialectDatabaseMetaData.java b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/metadata/AbstractDelegatingDialectDatabaseMetaData.java
index 63ee3a490b5..99da15276d9 100644
--- a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/metadata/AbstractDelegatingDialectDatabaseMetaData.java
+++ b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/metadata/AbstractDelegatingDialectDatabaseMetaData.java
@@ -17,6 +17,8 @@
 
 package org.apache.shardingsphere.database.connector.core.metadata.database.metadata;
 
+import lombok.AccessLevel;
+import lombok.RequiredArgsConstructor;
 import org.apache.shardingsphere.database.connector.core.metadata.database.enums.NullsOrderType;
 import org.apache.shardingsphere.database.connector.core.metadata.database.enums.QuoteCharacter;
 import org.apache.shardingsphere.database.connector.core.metadata.database.metadata.option.IdentifierPatternType;
@@ -36,7 +38,6 @@ import org.apache.shardingsphere.database.connector.core.metadata.database.metad
 import org.apache.shardingsphere.database.connector.core.metadata.database.metadata.option.transaction.DialectTransactionOption;
 import org.apache.shardingsphere.database.connector.core.metadata.database.metadata.option.version.DialectProtocolVersionOption;
 
-import java.util.Objects;
 import java.util.Optional;
 
 /**
@@ -44,20 +45,11 @@ import java.util.Optional;
  *
  * <p>Subclasses own database type identity and may override dialect-specific behavior.</p>
  */
+@RequiredArgsConstructor(access = AccessLevel.PROTECTED)
 public abstract class AbstractDelegatingDialectDatabaseMetaData implements DialectDatabaseMetaData {
     
     private final DialectDatabaseMetaData delegate;
     
-    /**
-     * Construct a delegating dialect database meta data.
-     *
-     * @param delegate dialect database meta data delegate
-     * @throws NullPointerException if delegate is null
-     */
-    protected AbstractDelegatingDialectDatabaseMetaData(final DialectDatabaseMetaData delegate) {
-        this.delegate = Objects.requireNonNull(delegate);
-    }
-    
     @Override
     public QuoteCharacter getQuoteCharacter() {
         return delegate.getQuoteCharacter();
diff --git a/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/util/SQLScriptUtils.java b/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/util/SQLScriptUtils.java
index 2ceb69f95f3..9804054012a 100644
--- a/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/util/SQLScriptUtils.java
+++ b/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/util/SQLScriptUtils.java
@@ -101,7 +101,7 @@ public final class SQLScriptUtils {
                 if (null == sql) {
                     break;
                 }
-                if (containsNonWhitespace(sql)) {
+                if (IntStream.range(0, sql.length()).anyMatch(each -> !Character.isWhitespace(sql.charAt(each)))) {
                     result.add(sql);
                 }
             }
@@ -114,10 +114,6 @@ public final class SQLScriptUtils {
         return null == resourceAsStream ? new FileReader(scriptFilePath) : new BufferedReader(new InputStreamReader(resourceAsStream, StandardCharsets.UTF_8));
     }
     
-    private static boolean containsNonWhitespace(final String value) {
-        return IntStream.range(0, value.length()).anyMatch(each -> !Character.isWhitespace(value.charAt(each)));
-    }
-    
     private static void executeBatch(final Connection connection, final Collection<String> sqls) throws SQLException {
         int count = 0;
         try (Statement statement = connection.createStatement()) {