You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by hvanhovell <gi...@git.apache.org> on 2018/10/11 08:47:47 UTC

[GitHub] spark pull request #22576: [SPARK-25560][SQL] Allow FunctionInjection in Spa...

Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22576#discussion_r224364692
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala ---
    @@ -168,4 +173,22 @@ class SparkSessionExtensions {
       def injectParser(builder: ParserBuilder): Unit = {
         parserBuilders += builder
       }
    +
    +  private[this] val injectedFunctions =
    +    mutable.Buffer.empty[FunctionDescription]
    +
    +    private[sql] def registerFunctions(functionRegistry: FunctionRegistry) = {
    --- End diff --
    
    Can you fix the indentation for the next 14 lines?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org