You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/06/03 20:03:26 UTC
Re: Review Request 33241: docs: Add documentation on observability
metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review86442
-----------------------------------------------------------
docs/home.md
<https://reviews.apache.org/r/33241/#comment138454>
I would call this file monitoring because it talks about metrics and alerts.
[Monitoring] /documentation/latest/monitoring/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138451>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138450>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138449>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138448>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138447>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138446>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138430>
Number of tasks that were invalid.
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138431>
There are also fine grained metrics about task lost reasons.
e.g:
master/task_failed/source_slave/reason_memory_limit
It is worth documenting these.
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138436>
s/aborted/terminated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138438>
s/used/allocated/
this was a bad metric name. we will figure out how to rename it to allocated in the future.
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138440>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138441>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138442>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138444>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138445>
s/used/allocated/
docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138452>
Can you add some basic alerts for slaves too like you did for master?
- Vinod Kone
On May 12, 2015, 8:43 p.m., Ricardo Cervera-Navarro wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33241/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 8:43 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2621
> https://issues.apache.org/jira/browse/MESOS-2621
>
>
> Repository: mesos
>
>
> Description
> -------
>
> docs: Add documentation on observability metrics.
>
>
> Diffs
> -----
>
> docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea
> docs/metrics.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33241/diff/
>
>
> Testing
> -------
>
> - Previewed in markdown editor.
> - Replaced page content using the Element Inspector in Chrome to ensure that the tables look good.
>
>
> File Attachments
> ----------------
>
> mesosmetrics2.webarchive
> https://reviews.apache.org/media/uploaded/files/2015/04/27/b89946c8-f709-4bca-b610-affd584c62f3__mesosmetrics2.webarchive
>
>
> Thanks,
>
> Ricardo Cervera-Navarro
>
>
Re: Review Request 33241: docs: Add documentation on observability
metrics.
Posted by Ricardo Cervera-Navarro <rc...@twopensource.com>.
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/home.md, line 22
> > <https://reviews.apache.org/r/33241/diff/4/?file=956804#file956804line22>
> >
> > I would call this file monitoring because it talks about metrics and alerts.
> >
> > [Monitoring] /documentation/latest/monitoring/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 69
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line69>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 76
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line76>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 90
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line90>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 97
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line97>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 111
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line111>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 118
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line118>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 364
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line364>
> >
> > Number of tasks that were invalid.
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 417
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line417>
> >
> > There are also fine grained metrics about task lost reasons.
> >
> > e.g:
> >
> > master/task_failed/source_slave/reason_memory_limit
> >
> > It is worth documenting these.
I don't have any more time to work on this assignment.
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 474
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line474>
> >
> > s/aborted/terminated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 777
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line777>
> >
> > s/used/allocated/
> >
> > this was a bad metric name. we will figure out how to rename it to allocated in the future.
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 784
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line784>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 798
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line798>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 805
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line805>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 819
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line819>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 826
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line826>
> >
> > s/used/allocated/
Done
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 1057
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line1057>
> >
> > Can you add some basic alerts for slaves too like you did for master?
I don't have any more time to work on this assignment.
- Ricardo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review86442
-----------------------------------------------------------
On June 24, 2015, 9:28 a.m., Ricardo Cervera-Navarro wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33241/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 9:28 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2621
> https://issues.apache.org/jira/browse/MESOS-2621
>
>
> Repository: mesos
>
>
> Description
> -------
>
> docs: Add documentation on observability metrics.
>
>
> Diffs
> -----
>
> docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33241/diff/
>
>
> Testing
> -------
>
> - Previewed in markdown editor.
> - Replaced page content using the Element Inspector in Chrome to ensure that the tables look good.
>
>
> File Attachments
> ----------------
>
> mesosmetrics2.webarchive
> https://reviews.apache.org/media/uploaded/files/2015/04/27/b89946c8-f709-4bca-b610-affd584c62f3__mesosmetrics2.webarchive
>
>
> Thanks,
>
> Ricardo Cervera-Navarro
>
>
Re: Review Request 33241: docs: Add documentation on observability
metrics.
Posted by Joe Smith <ya...@gmail.com>.
> On June 3, 2015, 11:03 a.m., Vinod Kone wrote:
> > docs/metrics.md, line 417
> > <https://reviews.apache.org/r/33241/diff/4/?file=956805#file956805line417>
> >
> > There are also fine grained metrics about task lost reasons.
> >
> > e.g:
> >
> > master/task_failed/source_slave/reason_memory_limit
> >
> > It is worth documenting these.
>
> Ricardo Cervera-Navarro wrote:
> I don't have any more time to work on this assignment.
I think for adding more metrics we can lean on a new review + submitter- likely best to get this coverage in now (is my preference)
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review86442
-----------------------------------------------------------
On June 24, 2015, 9:28 a.m., Ricardo Cervera-Navarro wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33241/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 9:28 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2621
> https://issues.apache.org/jira/browse/MESOS-2621
>
>
> Repository: mesos
>
>
> Description
> -------
>
> docs: Add documentation on observability metrics.
>
>
> Diffs
> -----
>
> docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea
> docs/monitoring.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33241/diff/
>
>
> Testing
> -------
>
> - Previewed in markdown editor.
> - Replaced page content using the Element Inspector in Chrome to ensure that the tables look good.
>
>
> File Attachments
> ----------------
>
> mesosmetrics2.webarchive
> https://reviews.apache.org/media/uploaded/files/2015/04/27/b89946c8-f709-4bca-b610-affd584c62f3__mesosmetrics2.webarchive
>
>
> Thanks,
>
> Ricardo Cervera-Navarro
>
>