[GitHub] [helix] pkuwm commented on a change in pull request #592: Add a ZkAddress-based constructor for ConfigAccessor

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #592: Add a ZkAddress-based constructor for ConfigAccessor
URL: https://github.com/apache/helix/pull/592#discussion_r346642774
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
 ##########
 @@ -67,14 +68,31 @@
     // @formatter:on
   }
 
-  private final HelixZkClient zkClient;
+  private final HelixZkClient _zkClient;
 
 Review comment:
   We are not expecting unrelated changes in a PR, right? I think if this name change is put in another PR, it would make this PR easier to review, because you can see the name change brings in noise(so many lines of change in this file).  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org