[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #281: Add FunctionConverters, FutureConverters and ObjectConverters

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin commented on code in PR #281:
URL: https://github.com/apache/incubator-pekko/pull/281#discussion_r1159993770


##########
actor/src/main/scala/org/apache/pekko/actor/Actor.scala:
##########
@@ -100,8 +100,8 @@ final case class ActorIdentity(correlationId: Any, ref: Option[ActorRef]) {
    * not defined if no actor matched the request.
    */
   def getActorRef: Optional[ActorRef] = {
-    import scala.compat.java8.OptionConverters._
-    ref.asJava
+    import pekko.util.OptionConverters._
+    ref.toJava

Review Comment:
   so all the `as` changed to `to`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org