You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/10/29 08:55:21 UTC

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #1065: nimble/host/include/host/ble_gap: expose ble_gap_adv_active_instance

sjanc commented on a change in pull request #1065:
URL: https://github.com/apache/mynewt-nimble/pull/1065#discussion_r739056094



##########
File path: nimble/host/src/ble_gap.c
##########
@@ -1294,14 +1294,12 @@ ble_gap_master_in_progress(void)
 #endif
 }
 
-#if NIMBLE_BLE_ADVERTISE || NIMBLE_BLE_CONNECT
-static int
+int
 ble_gap_adv_active_instance(uint8_t instance)
 {
     /* Assume read is atomic; mutex not necessary. */

Review comment:
       There is already ble_gap_adv_active() for legacy API.
   
   So I'd add new API ble_gap_ext_adv_active() (under EXT_ADV ifdef)  that would wrap this (and check if instance is valid)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org