You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by GitBox <gi...@apache.org> on 2022/10/22 17:04:53 UTC
[GitHub] [jspwiki] arturobernalg opened a new pull request, #242: Implement PDM maven plugin
arturobernalg opened a new pull request, #242:
URL: https://github.com/apache/jspwiki/pull/242
HI @juanpablo-santos
.As a workaround I disabled the fails on run errors. If we finally desired add this plugin then I'll fix all the bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement PMD maven plugin (jspwiki)
Posted by "juanpablo-santos (via GitHub)" <gi...@apache.org>.
juanpablo-santos commented on code in PR #242:
URL: https://github.com/apache/jspwiki/pull/242#discussion_r1162005963
##########
pom.xml:
##########
@@ -472,6 +474,21 @@
</execution>
</executions>
</plugin>
+
+ <plugin>
Review Comment:
I'd rather not include it, mainly because of two reasons
* You can still `mvn pmd:check` or `mvn pmd:pmd` and get the same result
* Having a quick look at the report, it suggests a lot of changes that (for me) make the code harder to read without any real benefit (collapsible ifs, superfluous parenthesis), so I'm not very comfortable blindly following the report
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jspwiki] arturobernalg commented on pull request #242: Implement PDM maven plugin
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on PR #242:
URL: https://github.com/apache/jspwiki/pull/242#issuecomment-1287856907
> HI @juanpablo-santos
> .As a workaround I disabled the fails on run errors. If we finally desired add this plugin then I'll fix all the bugs. This also can be added as a default build. Please take a look https://github.com/apache/jspwiki/pull/241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement PMD maven plugin (jspwiki)
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #242:
URL: https://github.com/apache/jspwiki/pull/242#issuecomment-1537219141
OK. I close the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement PMD maven plugin (jspwiki)
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg closed pull request #242: Implement PMD maven plugin
URL: https://github.com/apache/jspwiki/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org