You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2018/12/31 17:39:41 UTC

[GitHub] guacamole-client pull request #352: GUACAMOLE-684: Insufficient credentials ...

GitHub user necouchman opened a pull request:

    https://github.com/apache/guacamole-client/pull/352

    GUACAMOLE-684: Insufficient credentials should take precedence over other failures

    This resolves an issue where, depending on the order of stacked authentication modules, `GuacamoleInsufficientCredentialsException`s are overriden by `GuacamoleInvalidCredentialsException`s that occur prior to the insufficient exceptions.  This particular issue has come up with the RADIUS module when it gets a challenge/response and is stacked on top of the JDBC module, where the JDBC authentication occurs (and fails) prior to the RADIUS authentication attempt, and the additional credentials are never requested.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/necouchman/guacamole-client jira/684

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-client/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
    
----
commit a710558854092a162161d8e66d1634b5831e1824
Author: Nick Couchman <vn...@...>
Date:   2018-12-31T17:37:03Z

    GUACAMOLE-684: Insufficient credentials should take precedence over other credentials errors.

----


---