[jira] [Created] (SCM-907) GitScmProviderRepository#parseUrl() does not comply with RFC 3986 and RFC 8089

["Michael Osipov (JIRA)" <ji...@apache.org>]

Michael Osipov created SCM-907:
----------------------------------

             Summary: GitScmProviderRepository#parseUrl() does not comply with RFC 3986 and RFC 8089
                 Key: SCM-907
                 URL: https://issues.apache.org/jira/browse/SCM-907
             Project: Maven SCM
          Issue Type: Bug
          Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
    Affects Versions: 1.10.0
            Reporter: Michael Osipov


This issue was been found on one of Jenkins slaves. Consider the following path: {{F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2\m\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\target}}. THe aforementioned class outputs:
{noformat}
file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_SCM-906-3AXCXWOA5KAAL37TCEKGJUQCHVU3HMOGCVV63JP76C24C3X6DHOA@2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
file://2/m/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/target
{noformat}

The parse logic incorrectly assumes that the last {{@}} is for the user info. According to RFC 8089 a file URL may contain this information, but our parser would still fail becuase it uses {{lastIndexOf}}. It must stop searching to the first slash.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)