You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/25 07:59:44 UTC
[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #15757: Issue 15750: PIP-105: Store Subscription properties
nicoloboschi commented on code in PR #15757:
URL: https://github.com/apache/pulsar/pull/15757#discussion_r881336188
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -313,6 +316,52 @@ public Map<String, Long> getProperties() {
return lastMarkDeleteEntry != null ? lastMarkDeleteEntry.properties : Collections.emptyMap();
}
+ @Override
+ public Map<String, String> getCursorProperties() {
+ return cursorProperties;
+ }
+
+ @Override
+ public CompletableFuture<Void> updateCursorProperties(Map<String, String> cursorProperties) {
+ CompletableFuture<Void> updateCursorPropertiesResult = new CompletableFuture<>();
+ ledger.getStore().asyncGetCursorInfo(ledger.getName(), name, new MetaStoreCallback<>() {
+ @Override
+ public void operationComplete(ManagedCursorInfo info, Stat stat) {
+ ManagedCursorInfo copy = ManagedCursorInfo
+ .newBuilder(info)
+ .clearCursorProperties()
+ .addAllCursorProperties(buildStringPropertiesMap(cursorProperties))
+ .build();
+ ledger.getStore().asyncUpdateCursorInfo(ledger.getName(),
+ name, copy, stat, new MetaStoreCallback<>() {
+ @Override
+ public void operationComplete(Void result, Stat stat) {
+ log.info("[{}] Updated ledger cursor: {} properties {}", ledger.getName(),
+ name, cursorProperties);
+ ManagedCursorImpl.this.cursorProperties = cursorProperties;
+ cursorLedgerStat = stat;
+ updateCursorPropertiesResult.complete(result);
+ }
+
+ @Override
+ public void operationFailed(MetaStoreException e) {
+ log.info("[{}] Error while updating ledger cursor: {} properties {}", ledger.getName(),
Review Comment:
log.error ?
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -313,6 +316,52 @@ public Map<String, Long> getProperties() {
return lastMarkDeleteEntry != null ? lastMarkDeleteEntry.properties : Collections.emptyMap();
}
+ @Override
+ public Map<String, String> getCursorProperties() {
+ return cursorProperties;
+ }
+
+ @Override
+ public CompletableFuture<Void> updateCursorProperties(Map<String, String> cursorProperties) {
+ CompletableFuture<Void> updateCursorPropertiesResult = new CompletableFuture<>();
+ ledger.getStore().asyncGetCursorInfo(ledger.getName(), name, new MetaStoreCallback<>() {
+ @Override
+ public void operationComplete(ManagedCursorInfo info, Stat stat) {
+ ManagedCursorInfo copy = ManagedCursorInfo
+ .newBuilder(info)
+ .clearCursorProperties()
+ .addAllCursorProperties(buildStringPropertiesMap(cursorProperties))
+ .build();
+ ledger.getStore().asyncUpdateCursorInfo(ledger.getName(),
+ name, copy, stat, new MetaStoreCallback<>() {
+ @Override
+ public void operationComplete(Void result, Stat stat) {
+ log.info("[{}] Updated ledger cursor: {} properties {}", ledger.getName(),
+ name, cursorProperties);
+ ManagedCursorImpl.this.cursorProperties = cursorProperties;
+ cursorLedgerStat = stat;
+ updateCursorPropertiesResult.complete(result);
+ }
+
+ @Override
+ public void operationFailed(MetaStoreException e) {
+ log.info("[{}] Error while updating ledger cursor: {} properties {}", ledger.getName(),
+ name, cursorProperties, e);
+ updateCursorPropertiesResult.completeExceptionally(e);
+ }
+ });
+ }
+
+ @Override
+ public void operationFailed(MetaStoreException e) {
+ log.info("[{}] Error while updating ledger cursor: {} properties {}", ledger.getName(),
Review Comment:
log.error ?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -1094,6 +1094,20 @@ public Map<String, String> getSubscriptionProperties() {
return subscriptionProperties;
}
+ @Override
+ public CompletableFuture<Void> updateSubscriptionProperties(Map<String, String> subscriptionProperties) {
+ Map<String, String> newSubscriptionProperties;
+ if (subscriptionProperties == null) {
Review Comment:
or empty ?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentSubscription.java:
##########
@@ -526,4 +526,15 @@ public void updateLastActive() {
public Map<String, String> getSubscriptionProperties() {
return subscriptionProperties;
}
+
+ @Override
+ public CompletableFuture<Void> updateSubscriptionProperties(Map<String, String> subscriptionProperties) {
+ if (subscriptionProperties == null) {
Review Comment:
or empty ?
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2619,6 +2683,20 @@ private List<LongProperty> buildPropertiesMap(Map<String, Long> properties) {
return longProperties;
}
+ private static List<StringProperty> buildStringPropertiesMap(Map<String, String> properties) {
+ if (properties == null || properties.isEmpty()) {
+ return Collections.emptyList();
+ }
+
+ List<StringProperty> stringProperties = Lists.newArrayList();
Review Comment:
nit: we can create a list with the same size of properties#size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org