You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Piotr Nowojski (JIRA)" <ji...@apache.org> on 2019/06/06 09:20:00 UTC

[jira] [Commented] (FLINK-11876) Introduce the new interfaces InputSelectable, BoundedOneInput and BoundedMultiInput

    [ https://issues.apache.org/jira/browse/FLINK-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857464#comment-16857464 ] 

Piotr Nowojski commented on FLINK-11876:
----------------------------------------

After some discussion regarding the potential future interactions of this feature with vectorized/columnar processing or micro batching, we decided to change the contract of those interfaces.
{quote}Just to recap, we are currently agreeing on the looser contract of InputSelection, namely:
 if operator changes the input selection, this decision can take some time (for example up to one `NetworkBuffer` of records) to be taken into account.

This doesn’t require any changes to the currently proposed code/interfaces, `HashJoin` (Blink/Flink SQL) is compatible with that semantic, because it only changes the `InputSelection` once build side is empty/finished, thus no changes required there. Potential `SortMergeJoin` require a little bit of different logic if we decide to keep this semantic.

We are choosing this semantic because:
 - we are not sure if we will want to have micro batching in the future
 - we do not know at the moment if we would implement micro batching as a meta record of multiple records, or list of records, neither we do not know at the moment how we would expose this to the final user, and I can see that stricter semantic might collide with some of those variants
 - If we finally decide on how we want to implement micro batching, we can decide if we either want to keep the looser semantic or we can change without problems to the stricter semantic (without changes to the operators){quote}

> Introduce the new interfaces InputSelectable, BoundedOneInput and BoundedMultiInput
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-11876
>                 URL: https://issues.apache.org/jira/browse/FLINK-11876
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Operators
>            Reporter: Haibo Sun
>            Assignee: Haibo Sun
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)