You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Stefan Groschupf (JIRA)" <ji...@apache.org> on 2006/07/19 23:39:14 UTC

[jira] Created: (NUTCH-323) CrawlDatum.set just reference a mapWritable of a other object but not copy it.

CrawlDatum.set just reference a mapWritable of a other object but not copy it.
------------------------------------------------------------------------------

                 Key: NUTCH-323
                 URL: http://issues.apache.org/jira/browse/NUTCH-323
             Project: Nutch
          Issue Type: Bug
    Affects Versions: 0.8-dev
            Reporter: Stefan Groschupf
            Priority: Critical
             Fix For: 0.8-dev


Using CrawlDatum.set(aOtherCrawlDatum) copies the data from one CrawlDatum to a other. 
Also a reference of the MapWritable is passed. Means both project share the same mapWritable and its content. 
This causes problems with concurent manipulate mapWritables and its key-value tuples. 



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (NUTCH-323) CrawlDatum.set just reference a mapWritable of a other object but not copy it.

Posted by "Stefan Groschupf (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/NUTCH-323?page=all ]

Stefan Groschupf updated NUTCH-323:
-----------------------------------

    Attachment: MapWritableCopyConstructor.patch

Attached patch add a copy constructor to  the map writable and use it in the CrawlDatum.set methode. However there are more methods in the code where meta data are passed from one CrawlDatum to a other, but I don't can see any risk of concurent usage of the mapWritable there. 


> CrawlDatum.set just reference a mapWritable of a other object but not copy it.
> ------------------------------------------------------------------------------
>
>                 Key: NUTCH-323
>                 URL: http://issues.apache.org/jira/browse/NUTCH-323
>             Project: Nutch
>          Issue Type: Bug
>    Affects Versions: 0.8-dev
>            Reporter: Stefan Groschupf
>            Priority: Critical
>             Fix For: 0.8-dev
>
>         Attachments: MapWritableCopyConstructor.patch
>
>
> Using CrawlDatum.set(aOtherCrawlDatum) copies the data from one CrawlDatum to a other. 
> Also a reference of the MapWritable is passed. Means both project share the same mapWritable and its content. 
> This causes problems with concurent manipulate mapWritables and its key-value tuples. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (NUTCH-323) CrawlDatum.set just reference a mapWritable of a other object but not copy it.

Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/NUTCH-323?page=all ]

Andrzej Bialecki  closed NUTCH-323.
-----------------------------------

    Resolution: Fixed
      Assignee: Andrzej Bialecki 

Patch applied to trunk/ . This should solve some serious issues with CrawlDatum.metaData handling in CrawlDbReducer. Thank you!

> CrawlDatum.set just reference a mapWritable of a other object but not copy it.
> ------------------------------------------------------------------------------
>
>                 Key: NUTCH-323
>                 URL: http://issues.apache.org/jira/browse/NUTCH-323
>             Project: Nutch
>          Issue Type: Bug
>    Affects Versions: 0.8-dev
>            Reporter: Stefan Groschupf
>         Assigned To: Andrzej Bialecki 
>            Priority: Critical
>             Fix For: 0.8-dev
>
>         Attachments: MapWritableCopyConstructor.patch
>
>
> Using CrawlDatum.set(aOtherCrawlDatum) copies the data from one CrawlDatum to a other. 
> Also a reference of the MapWritable is passed. Means both project share the same mapWritable and its content. 
> This causes problems with concurent manipulate mapWritables and its key-value tuples. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira