You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/10 10:47:58 UTC
Review Request 28895: CLOUDSTACK-8057:
test_dedicate_guest_vlan_range.py - Marking a test as invalid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28895/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8057
https://issues.apache.org/jira/browse/CLOUDSTACK-8057
Repository: cloudstack-git
Description
-------
The test case dedicates the vlan range to account but creates guest network in project, and then checks if the vlan of the network is from dedicated range.
This is an invalid scenario.
Will add new test case for dedicating vlan to project and creating guest networks in project after verifying manually.
Diffs
-----
test/integration/component/test_dedicate_guest_vlan_ranges.py 29bc280
Diff: https://reviews.apache.org/r/28895/diff/
Testing
-------
N/A
Thanks,
Gaurav Aradhye
Re: Review Request 28895: CLOUDSTACK-8057:
test_dedicate_guest_vlan_range.py - Marking a test as invalid
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28895/#review64537
-----------------------------------------------------------
Ship it!
pushed to 4.5 and master
- SrikanteswaraRao Talluri
On Dec. 10, 2014, 9:47 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28895/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 9:47 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8057
> https://issues.apache.org/jira/browse/CLOUDSTACK-8057
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case dedicates the vlan range to account but creates guest network in project, and then checks if the vlan of the network is from dedicated range.
>
> This is an invalid scenario.
>
> Will add new test case for dedicating vlan to project and creating guest networks in project after verifying manually.
>
>
> Diffs
> -----
>
> test/integration/component/test_dedicate_guest_vlan_ranges.py 29bc280
>
> Diff: https://reviews.apache.org/r/28895/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Gaurav Aradhye
>
>