You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/06 17:53:47 UTC
[GitHub] marcoabreu commented on a change in pull request #11169: Fix
ci/build.py using remote cache locally
marcoabreu commented on a change in pull request #11169: Fix ci/build.py using remote cache locally
URL: https://github.com/apache/incubator-mxnet/pull/11169#discussion_r193502162
##########
File path: ci/build.py
##########
@@ -221,56 +221,62 @@ def script_name() -> str:
help="go in a shell inside the container",
action='store_true')
- parser.add_argument("--docker-registry",
- help="Dockerhub registry name to retrieve cache from",
+ parser.add_argument("-d", "--docker-registry",
+ help="Dockerhub registry name to retrieve cache from. Default is 'mxnetci'",
default='mxnetci',
type=str)
+ parser.add_argument("-c", "--cache", action="store_true",
Review comment:
We already have that check in https://github.com/larroy/mxnet/blob/1aca0a1d3fe772f13a957175ddb42449c393f585/ci/build.py#L164. Just remove the default value in https://github.com/larroy/mxnet/blob/1aca0a1d3fe772f13a957175ddb42449c393f585/ci/build.py#L226 and we're good.
I don't see much reason to have two options to manage this functionality
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services