You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "tylerbertrand (via GitHub)" <gi...@apache.org> on 2023/02/09 15:29:16 UTC
[GitHub] [solr] tylerbertrand opened a new pull request, #1345: Gradle: Use lazy file types
tylerbertrand opened a new pull request, #1345:
URL: https://github.com/apache/solr/pull/1345
<!-- https://issues.apache.org/jira/browse/SOLR-XXXXX -->
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
<!-- Please provide a short description of the changes you're making with this pull request. -->
Updated inputs defined in `CommandLineArgumentProvider`s to use lazy file types. While usage of "eager" file types is not currently causing issues, it is generally preferred to use lazy file types where possible to defer file evaluation to execution time.
# Solution
Replaced `File`s with their lazy counterparts: `DirectoryProperty` and `RegularFileProperty`
Build scan for these changes: https://scans.gradle.com/s/2rtoy5kx6cipa
# Tests
<!-- Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. -->
N/A - this PR only updates build logic
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1345: Gradle: Use lazy file types
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk merged PR #1345:
URL: https://github.com/apache/solr/pull/1345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1345: Gradle: Use lazy file types
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1345:
URL: https://github.com/apache/solr/pull/1345#issuecomment-1428392431
Thanks @tylerbertrand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1345: Gradle: Use lazy file types
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #1345:
URL: https://github.com/apache/solr/pull/1345#issuecomment-1426595948
Thanks for improving our build Tyler! It's a big build; anything helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tylerbertrand commented on pull request #1345: Gradle: Use lazy file types
Posted by "tylerbertrand (via GitHub)" <gi...@apache.org>.
tylerbertrand commented on PR #1345:
URL: https://github.com/apache/solr/pull/1345#issuecomment-1428408236
@uschindler Yup, working on that now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1345: Gradle: Use lazy file types
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1345:
URL: https://github.com/apache/solr/pull/1345#issuecomment-1428410463
I created https://github.com/apache/lucene/issues/12145 to track adding this to Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #1345: Gradle: Use lazy file types
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #1345:
URL: https://github.com/apache/solr/pull/1345#issuecomment-1428405423
Please remember to port this to Lucene!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org