You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "azatyamanaev (via GitHub)" <gi...@apache.org> on 2024/05/12 08:23:42 UTC
[PR] Increase [integration-tx-api] module test case coverage [incubator-seata]
azatyamanaev opened a new pull request, #6533:
URL: https://github.com/apache/incubator-seata/pull/6533
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
increase test case coverage of [integration-tx-api] module
### Ⅱ. Does this pull request fix one issue?
fixes #6507
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "lightClouds917 (via GitHub)" <gi...@apache.org>.
lightClouds917 commented on code in PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#discussion_r1627592240
##########
changes/en-us/2.x.md:
##########
@@ -153,6 +153,8 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] adjust the test cases related to dynamic configuration
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] support redis integration testing
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)] fix FileConfigurationTest and MockServerTest fail
+- [[#6545](https://github.com/apache/incubator-seata/pull/6545)] fix TestConfigCustomSPI compatibility test fail
+- [[#6533](https://github.com/apache/incubator-seata/pull/6533)] increase integration-tx-api module unit test coverage
Review Comment:
alse need to add into zh-cn/2.x.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on code in PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#discussion_r1628021571
##########
changes/en-us/2.x.md:
##########
@@ -153,6 +153,8 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] adjust the test cases related to dynamic configuration
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] support redis integration testing
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)] fix FileConfigurationTest and MockServerTest fail
+- [[#6545](https://github.com/apache/incubator-seata/pull/6545)] fix TestConfigCustomSPI compatibility test fail
+- [[#6533](https://github.com/apache/incubator-seata/pull/6533)] increase integration-tx-api module unit test coverage
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2120140005
> @xingfudeshi Can you resolve merge conflict?
Yes.The current version is being released.I'll resolve conflicts after the release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2120121768
@xingfudeshi Can you resolve merge conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on code in PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#discussion_r1628021571
##########
changes/en-us/2.x.md:
##########
@@ -153,6 +153,8 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] adjust the test cases related to dynamic configuration
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] support redis integration testing
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)] fix FileConfigurationTest and MockServerTest fail
+- [[#6545](https://github.com/apache/incubator-seata/pull/6545)] fix TestConfigCustomSPI compatibility test fail
+- [[#6533](https://github.com/apache/incubator-seata/pull/6533)] increase integration-tx-api module unit test coverage
Review Comment:
@lightClouds917 Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2210576375
我修复了codecov没有report成功的问题，现在让我们看看目前的单测覆盖度是多少
I've fixed the issue with Codecov not reporting successfully. Now, let's see what the current test coverage percentage is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "lightClouds917 (via GitHub)" <gi...@apache.org>.
lightClouds917 commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2185703292
> > please resolve the conflict
>
> I can't, I don't have write access to repository. Or should I rebase my branch?
you can merge the 2.x branch to your branch,and resolve the confict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2112487499
> Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2122563406
> > > @xingfudeshi Can you resolve merge conflict?
>
> >
>
> > Yes.The current version is being released.I'll resolve conflicts after the release.
>
>
>
> How long does it usually take?
It won’t take long. After version 2.1 is released, I will start addressing the conflicting files in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2115211671
> Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes
@xingfudeshi Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on code in PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#discussion_r1628023661
##########
changes/en-us/2.x.md:
##########
@@ -153,6 +153,8 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] adjust the test cases related to dynamic configuration
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] support redis integration testing
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)] fix FileConfigurationTest and MockServerTest fail
+- [[#6545](https://github.com/apache/incubator-seata/pull/6545)] fix TestConfigCustomSPI compatibility test fail
+- [[#6533](https://github.com/apache/incubator-seata/pull/6533)] increase integration-tx-api module unit test coverage
Review Comment:
> alse need to add into zh-cn/2.x.md
@lightClouds917 Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on code in PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#discussion_r1628021571
##########
changes/en-us/2.x.md:
##########
@@ -153,6 +153,8 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] adjust the test cases related to dynamic configuration
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] support redis integration testing
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)] fix FileConfigurationTest and MockServerTest fail
+- [[#6545](https://github.com/apache/incubator-seata/pull/6545)] fix TestConfigCustomSPI compatibility test fail
+- [[#6533](https://github.com/apache/incubator-seata/pull/6533)] increase integration-tx-api module unit test coverage
Review Comment:
> alse need to add into zh-cn/2.x.md
@lightClouds917 Done
##########
changes/en-us/2.x.md:
##########
@@ -153,6 +153,8 @@ Add changes here for all PR submitted to the 2.x branch.
- [[#6456](https://github.com/apache/incubator-seata/pull/6456)] adjust the test cases related to dynamic configuration
- [[#6466](https://github.com/apache/incubator-seata/pull/6466)] support redis integration testing
- [[#6484](https://github.com/apache/incubator-seata/pull/6484)] fix FileConfigurationTest and MockServerTest fail
+- [[#6545](https://github.com/apache/incubator-seata/pull/6545)] fix TestConfigCustomSPI compatibility test fail
+- [[#6533](https://github.com/apache/incubator-seata/pull/6533)] increase integration-tx-api module unit test coverage
Review Comment:
> alse need to add into zh-cn/2.x.md
@lightClouds917 Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2165122872
> please resolve the conflict
i can't, i don't have write access to repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2210592654
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6533?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 49.70%. Comparing base [(`933b492`)](https://app.codecov.io/gh/apache/incubator-seata/commit/933b492da88e145ca2b7f152ed3b03693936b068?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c6906a2`)](https://app.codecov.io/gh/apache/incubator-seata/commit/c6906a2a4a24bc6a7a3f91974f8112646e3d00f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 27 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6533 +/- ##
============================================
- Coverage 51.13% 49.70% -1.44%
- Complexity 5317 5575 +258
============================================
Files 950 1023 +73
Lines 33448 35440 +1992
Branches 4048 4216 +168
============================================
+ Hits 17103 17614 +511
- Misses 14666 16122 +1456
- Partials 1679 1704 +25
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6533?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ta/integration/tx/api/remoting/TwoPhaseResult.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6533?src=pr&el=tree&filepath=integration-tx-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fintegration%2Ftx%2Fapi%2Fremoting%2FTwoPhaseResult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZWdyYXRpb24tdHgtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9pbnRlZ3JhdGlvbi90eC9hcGkvcmVtb3RpbmcvVHdvUGhhc2VSZXN1bHQuamF2YQ==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
... and [114 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6533/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "azatyamanaev (via GitHub)" <gi...@apache.org>.
azatyamanaev commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2120193851
> > @xingfudeshi Can you resolve merge conflict?
>
> Yes.The current version is being released.I'll resolve conflicts after the release.
How long does it usually takes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test:Increase [integration-tx-api] module test case coverage [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #6533:
URL: https://github.com/apache/incubator-seata/pull/6533#issuecomment-2112036957
Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org