You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by ni...@apache.org on 2019/07/12 03:27:01 UTC

[servicecomb-pack] 03/05: SCB-1321 Fixed a typo of SagaActorState

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch SCB-1321-cleanup
in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git

commit d2226fc0c7806c68d82a05b0415d9abc0decb943
Author: Willem Jiang <wi...@gmail.com>
AuthorDate: Fri Jul 12 10:17:33 2019 +0800

    SCB-1321 Fixed a typo of SagaActorState
---
 .../servicecomb/pack/alpha/fsm/SagaActor.java      |  4 +-
 .../servicecomb/pack/alpha/fsm/SagaActorState.java |  2 +-
 .../servicecomb/pack/alpha/fsm/SagaActorTest.java  | 52 +++++++++++-----------
 3 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActor.java b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActor.java
index a6e3d05..7b07d4e 100644
--- a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActor.java
+++ b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActor.java
@@ -61,9 +61,9 @@ public class SagaActor extends
   public SagaActor(String persistenceId) {
     this.persistenceId = persistenceId;
 
-    startWith(SagaActorState.IDEL, SagaData.builder().build());
+    startWith(SagaActorState.IDLE, SagaData.builder().build());
 
-    when(SagaActorState.IDEL,
+    when(SagaActorState.IDLE,
         matchEvent(SagaStartedEvent.class,
             (event, data) -> {
               SagaStartedDomain domainEvent = new SagaStartedDomain(event);
diff --git a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorState.java b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorState.java
index 212e47b..7c7c6ad 100644
--- a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorState.java
+++ b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorState.java
@@ -20,7 +20,7 @@ package org.apache.servicecomb.pack.alpha.fsm;
 import akka.persistence.fsm.PersistentFSM;
 
 public enum SagaActorState implements PersistentFSM.FSMState {
-  IDEL,
+  IDLE,
   READY,
   PARTIALLY_ACTIVE,
   PARTIALLY_COMMITTED,
diff --git a/alpha/alpha-fsm/src/test/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorTest.java b/alpha/alpha-fsm/src/test/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorTest.java
index 505d923..c68c5d6 100644
--- a/alpha/alpha-fsm/src/test/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorTest.java
+++ b/alpha/alpha-fsm/src/test/java/org/apache/servicecomb/pack/alpha/fsm/SagaActorTest.java
@@ -110,10 +110,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -179,10 +179,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -262,10 +262,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -318,10 +318,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -385,10 +385,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -458,10 +458,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -532,10 +532,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -595,10 +595,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -671,10 +671,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -741,9 +741,9 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -806,10 +806,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -863,10 +863,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);
@@ -928,10 +928,10 @@ public class SagaActorTest {
 
       //expect
       CurrentState currentState = expectMsgClass(PersistentFSM.CurrentState.class);
-      assertEquals(SagaActorState.IDEL, currentState.state());
+      assertEquals(SagaActorState.IDLE, currentState.state());
 
       PersistentFSM.Transition transition = expectMsgClass(PersistentFSM.Transition.class);
-      assertSagaTransition(transition, saga, SagaActorState.IDEL, SagaActorState.READY);
+      assertSagaTransition(transition, saga, SagaActorState.IDLE, SagaActorState.READY);
 
       transition = expectMsgClass(PersistentFSM.Transition.class);
       assertSagaTransition(transition, saga, SagaActorState.READY, SagaActorState.PARTIALLY_ACTIVE);