You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2018/04/23 22:12:35 UTC
[kudu-CR] WIP Workaround KUDU-2233 when the history was already deleted
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10163
Change subject: WIP Workaround KUDU-2233 when the history was already deleted
......................................................................
WIP Workaround KUDU-2233 when the history was already deleted
There is a rare case of KUDU-2233 where we might have already
deleted the history in a previous compaction, but haven't actually
crashed. This makes is possible for even a patched Kudu cluster
to run into KUDU-2233.
This patch adds a flags that allows to drop a row altogether when
we can't place it in the row history.
Change-Id: I90b78d27f0b6776bb004d9c7690980ac305628bb
---
M src/kudu/tablet/compaction.cc
1 file changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/10163/1
--
To view, visit http://gerrit.cloudera.org:8080/10163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90b78d27f0b6776bb004d9c7690980ac305628bb
Gerrit-Change-Number: 10163
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
[kudu-CR] WIP Workaround KUDU-2233 when the history was already deleted
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10163 )
Change subject: WIP Workaround KUDU-2233 when the history was already deleted
......................................................................
Patch Set 1:
I think we chatted about this approach on Slack shortly after you asked on 4/23. Any update on this? It would be nice to have this patch available when users hit the issue.
--
To view, visit http://gerrit.cloudera.org:8080/10163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90b78d27f0b6776bb004d9c7690980ac305628bb
Gerrit-Change-Number: 10163
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 21 May 2018 16:19:42 +0000
Gerrit-HasComments: No
[kudu-CR] WIP Workaround KUDU-2233 when the history was already deleted
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10163 )
Change subject: WIP Workaround KUDU-2233 when the history was already deleted
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:
http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc@65
PS1, Line 65: loosing
nit: losing
http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc@798
PS1, Line 798: pv_delete_redo != nullptr ||
: pv_delete_redo->changelist().is_delete() ||
: pv_delete_redo->next() == nullptr)
shouldn't all of these conditions be negated?
--
To view, visit http://gerrit.cloudera.org:8080/10163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90b78d27f0b6776bb004d9c7690980ac305628bb
Gerrit-Change-Number: 10163
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Apr 2018 22:43:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] WIP Workaround KUDU-2233 when the history was already deleted
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10163 )
Change subject: WIP Workaround KUDU-2233 when the history was already deleted
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:
http://gerrit.cloudera.org:8080/#/c/10163/1/src/kudu/tablet/compaction.cc@798
PS1, Line 798: pv_delete_redo != nullptr ||
: pv_delete_redo->changelist().is_delete() ||
: pv_delete_redo->next() == nullptr)
> shouldn't all of these conditions be negated?
doh, true, thanks. but what do you think of the approach in general?
--
To view, visit http://gerrit.cloudera.org:8080/10163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90b78d27f0b6776bb004d9c7690980ac305628bb
Gerrit-Change-Number: 10163
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Apr 2018 23:24:26 +0000
Gerrit-HasComments: Yes