You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/08/14 14:19:59 UTC
[GitHub] [arrow] paleolimbot opened a new pull request, #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
paleolimbot opened a new pull request, #37147:
URL: https://github.com/apache/arrow/pull/37147
### Rationale for this change
Currently a naive `install.packages("arrow")` will result in a failed build if gcc-13 is the compiler. This is because we include GCS by default on this type of build (bundled). CRAN's check farm includes at least one system where gcc-13 is the compiler and so we need can't error or suggest a user workaround.
### What changes are included in this PR?
This PR explicitly sets the relevant environment variable if the compiler string contains "gcc" and if `gcc --version` contains "13.XXX.XX". This is admittedly crude; however, the alternative of updating Abseil results in a cascading set of changes that may break other parts of Arrow. Few if any actual users will build the Arrow R package from source using gcc-13, so this has a much lower footprint (and a workaround: you can just set the GCS environment variable yourself before building if you do, in fact, want to attempt this).
### Are these changes tested?
Tested via crossbow (see below).
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677699043
@github-actions crossbow submit test-r-library-r-base-latest test-r-depsource-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677703072
Revision: 30cbe9ed2f1eb315611ec380b00b87884349dccf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c4616885b4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c4616885b4)
|Task|Status|
|----|------|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/15882339035)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/15882341147)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677513053
Revision: 095621b7f0514e62bf8f981b5bf8fc44489aec37
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b319a1c901](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b319a1c901)
|Task|Status|
|----|------|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/15879075714)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/15879076722)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1681575349
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3e7b35bacca776fbf2e3e313e32d872b73635c87.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15964691565) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677537082
@github-actions crossbow submit test-r-library-r-base-latest test-r-depsource-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677541265
Another workaround would be to explicitly provide the absl dependency instead of building from source. That way a build on gcc 13 would be possible with gcs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677412629
@github-actions crossbow submit est-r-library-r-base-latest test-r-depsource-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677413683
@github-actions crossbow submit test-r-library-r-base-latest test-r-depsource-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677418437
Revision: b59798b693f0bae340ed230d36c5ac6e43953a94
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2b1f8c7ba7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2b1f8c7ba7)
|Task|Status|
|----|------|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/15877624508)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/15877622559)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677508347
@github-actions crossbow submit test-r-library-r-base-latest test-r-depsource-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37147:
URL: https://github.com/apache/arrow/pull/37147#issuecomment-1677542220
Revision: 34657f20ba76ff6eb39b167ae00183bbbaadb3ea
Submitted crossbow builds: [ursacomputing/crossbow @ actions-dca0c8e764](https://github.com/ursacomputing/crossbow/branches/all?query=actions-dca0c8e764)
|Task|Status|
|----|------|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/15879642402)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/15879642908)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser merged pull request #37147: GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #37147:
URL: https://github.com/apache/arrow/pull/37147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org