[GitHub] [spark] HyukjinKwon commented on a change in pull request #33370: [SPARK-36163] Propagate correct JDBC properties in JDBC connector provider and add "connectionProvider" option

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #33370:
URL: https://github.com/apache/spark/pull/33370#discussion_r670885022



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProviderSuite.scala
##########
@@ -17,12 +17,21 @@
 
 package org.apache.spark.sql.execution.datasources.jdbc.connection
 
+import java.sql.{Connection, Driver}
 import javax.security.auth.login.Configuration
 
+import org.mockito.Mockito._

Review comment:
       shall we remove this import:
   
   ```
   [error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProviderSuite.scala:23:28: Unused import
   [error] import org.mockito.Mockito._
   [error]                            ^
   [error] one error found
   [error] (sql / Test / compileIncremental) Compilation failed
   [error] Total time: 599 s (09:59), completed Jul 15, 2021 2:48:41 PM
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org