You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/10 10:39:39 UTC

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4079: Fix be may core dump when linked schema change

wutiangan commented on a change in pull request #4079:
URL: https://github.com/apache/incubator-doris/pull/4079#discussion_r452766261



##########
File path: be/src/olap/rowset/segment_group.cpp
##########
@@ -256,7 +256,9 @@ OLAPStatus SegmentGroup::add_zone_maps_for_linked_schema_change(
 
     int zonemap_col_num = get_num_zone_map_columns();
     CHECK(zonemap_col_num <= schema_mapping.size()) << zonemap_col_num << " vs. " << schema_mapping.size();
-    for (size_t i = 0; i < zonemap_col_num; ++i) {
+    // if uprade from 0.11 the zone map not contain the value column, so zone_map_fields.size() is less

Review comment:
       ```suggestion
       // if upgrade from 0.11 the zone map not contain the value column, so zone_map_fields.size() is less
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org