You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/14 15:17:52 UTC

[GitHub] pnowojski commented on a change in pull request #7440: [FLINK-10591][table] Introduced functions to return time attributes from MATCH_RECOGNIZE

pnowojski commented on a change in pull request #7440:  [FLINK-10591][table] Introduced functions to return time attributes from MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/7440#discussion_r247510659
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
 ##########
 @@ -50,61 +49,6 @@ import org.apache.flink.util.MathUtils.checkedDownCast
 import scala.collection.JavaConverters._
 import scala.collection.mutable
 
-object MatchCodeGenerator {
 
 Review comment:
   Is this change of `MatchCodeGenerator` relevant to the migration from `PatternSelectFunction` to `PatternProcessFunction`? It looks like an independent refactor and could be extracted to separate commit?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services