You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2016/01/30 02:36:08 UTC
Review Request 42998: [7 of 7] Added docs for shareable resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325
Repository: mesos
Description
-------
Added docs for shareable resources.
Diffs
-----
docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
docs/shareable-resources.md PRE-CREATION
Diff: https://reviews.apache.org/r/42998/diff/
Testing
-------
Just documentation changes in this RR.
Thanks,
Anindya Sinha
Re: Review Request 42998: [7 of 7] Added docs for shareable resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/#review117099
-----------------------------------------------------------
docs/shareable-resources.md (line 19)
<https://reviews.apache.org/r/42998/#comment178181>
s/for persistent volumes/for persistent volumes currently
docs/shareable-resources.md (line 48)
<https://reviews.apache.org/r/42998/#comment178182>
Can you please clarify how does "multiple writers" works? Does there are any confilict if multiple tasks write to same resource?
docs/shareable-resources.md (line 65)
<https://reviews.apache.org/r/42998/#comment178185>
Can you please add more detail for how does "num_consumers" value changed? i.e. When to increase, when to decrease?
docs/shareable-resources.md (lines 78 - 79)
<https://reviews.apache.org/r/42998/#comment178183>
Not only framework, but also operator http endpoint.
I think that we should also clarify that the SHARE & UNSHARE do not support operator http endpoint,
- Guangya Liu
On 一月 30, 2016, 1:36 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42998/
> -----------------------------------------------------------
>
> (Updated 一月 30, 2016, 1:36 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4325
> https://issues.apache.org/jira/browse/MESOS-4325
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added docs for shareable resources.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
> docs/shareable-resources.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42998/diff/
>
>
> Testing
> -------
>
> Just documentation changes in this RR.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 42998: [7 of 7] Added docs for shareable resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/#review117096
-----------------------------------------------------------
Bad patch!
Reviews applied: [42992]
Failed command: ./support/apply-review.sh -n -r 42992
Error:
2016-01-30 05:20:01 URL:https://reviews.apache.org/r/42992/diff/raw/ [49098/49098] -> "42992.patch" [1]
Total errors found: 0
Checking 11 files
Error: Commit message summary (the first line) must start with a capital letter.
Full log: https://builds.apache.org/job/mesos-reviewbot/11132/console
- Mesos ReviewBot
On Jan. 30, 2016, 1:36 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42998/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2016, 1:36 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4325
> https://issues.apache.org/jira/browse/MESOS-4325
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added docs for shareable resources.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
> docs/shareable-resources.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42998/diff/
>
>
> Testing
> -------
>
> Just documentation changes in this RR.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 42998: Added docs for shareable resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/#review118146
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42992, 42993, 42994, 42995, 42996, 42997, 42998]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 5, 2016, 10:59 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42998/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 10:59 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4325
> https://issues.apache.org/jira/browse/MESOS-4325
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added docs for shareable resources.
>
>
> Diffs
> -----
>
> docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88
> docs/shareable-resources.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42998/diff/
>
>
> Testing
> -------
>
> Just documentation changes in this RR.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 42998: Added docs for shareable resources.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 10:59 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325
Repository: mesos
Description
-------
Added docs for shareable resources.
Diffs (updated)
-----
docs/home.md a2000a35a6eeaa7b36cb1796532263f5a703ac88
docs/shareable-resources.md PRE-CREATION
Diff: https://reviews.apache.org/r/42998/diff/
Testing
-------
Just documentation changes in this RR.
Thanks,
Anindya Sinha
Re: Review Request 42998: Added docs for shareable resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/#review117349
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42992, 42993, 42994, 42995, 42996, 42997, 42998]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 2, 2016, 12:39 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42998/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 12:39 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4325
> https://issues.apache.org/jira/browse/MESOS-4325
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added docs for shareable resources.
>
>
> Diffs
> -----
>
> docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
> docs/shareable-resources.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42998/diff/
>
>
> Testing
> -------
>
> Just documentation changes in this RR.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 42998: Added docs for shareable resources.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42998/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 12:39 a.m.)
Review request for mesos and Adam B.
Summary (updated)
-----------------
Added docs for shareable resources.
Bugs: MESOS-4325
https://issues.apache.org/jira/browse/MESOS-4325
Repository: mesos
Description
-------
Added docs for shareable resources.
Diffs (updated)
-----
docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec
docs/shareable-resources.md PRE-CREATION
Diff: https://reviews.apache.org/r/42998/diff/
Testing
-------
Just documentation changes in this RR.
Thanks,
Anindya Sinha