You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/12 09:19:45 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #20349: Fix Scheduler crash when executing task instances of missing DAG

kaxil commented on a change in pull request #20349:
URL: https://github.com/apache/airflow/pull/20349#discussion_r782858400



##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -645,6 +645,34 @@ def test_find_executable_task_instances_in_default_pool(self, dag_maker):
         session.rollback()
         session.close()
 
+    def test_executable_task_instances_to_queued_fails_task_for_missing_dag_in_dagbag(
+        self, dag_maker, session
+    ):
+        """Only check concurrency for dag in dagbag"""

Review comment:
       docstring are wrong

##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -645,6 +645,34 @@ def test_find_executable_task_instances_in_default_pool(self, dag_maker):
         session.rollback()
         session.close()
 
+    def test_executable_task_instances_to_queued_fails_task_for_missing_dag_in_dagbag(
+        self, dag_maker, session
+    ):
+        """Only check concurrency for dag in dagbag"""

Review comment:
       docstring is wrong




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org