You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/11 11:49:07 UTC

[GitHub] [incubator-seatunnel] wenwei8268 opened a new pull request, #3064: [Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type

wenwei8268 opened a new pull request, #3064:
URL: https://github.com/apache/incubator-seatunnel/pull/3064

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X closed pull request #3064: [Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type

Posted by GitBox <gi...@apache.org>.
Hisoka-X closed pull request #3064: [Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type
URL: https://github.com/apache/incubator-seatunnel/pull/3064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3064: [Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3064:
URL: https://github.com/apache/incubator-seatunnel/pull/3064#issuecomment-1278379543

   We should support it both source side and sink side, so we should test read int128 from clickhouse source and write it into clickhouse table.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3064: [Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type

Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3064:
URL: https://github.com/apache/incubator-seatunnel/pull/3064#issuecomment-1278386842

   Can you push your idea to #3067 ? The PR is duplicated, or you can pick up another issue. Thanks！


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] FWLamb commented on pull request #3064: [Improve] [Clickhouse-V2] Clickhouse Support Int128,Int256 Type

Posted by GitBox <gi...@apache.org>.
FWLamb commented on PR #3064:
URL: https://github.com/apache/incubator-seatunnel/pull/3064#issuecomment-1274587585

   Doesn't this result in parsing errors？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org