You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/08/12 11:32:53 UTC

[GitHub] [ignite] anton-vinogradov commented on a change in pull request #8142: Fix measuring timers in discovery tests

anton-vinogradov commented on a change in pull request #8142:
URL: https://github.com/apache/ignite/pull/8142#discussion_r469192064



##########
File path: modules/ducktests/tests/ignitetest/tests/discovery_test.py
##########
@@ -32,41 +37,58 @@
 # pylint: disable=W0223
 class DiscoveryTest(IgniteTest):
     """
-    Test basic discovery scenarious (TCP and Zookeeper).
+    Test various node failure scenarios (TCP and ZooKeeper).
     1. Start of ignite cluster.
     2. Kill random node.
     3. Wait that survived node detects node failure.
     """
     NUM_NODES = 7
 
+    FAILURE_DETECTION_TIMEOUT = 2000
+
+    __LOG_PATH = os.path.join(IgniteAwareService.PERSISTENT_ROOT, "console.log")

Review comment:
       why not gain from IgniteAwareService?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org