You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/19 09:55:59 UTC
[GitHub] [apisix-website] qier222 opened a new pull request #197: style: redesign team page
qier222 opened a new pull request #197:
URL: https://github.com/apache/apisix-website/pull/197
### Changes:
style: redesign team page
### Screenshots of the change:
<img width="1395" alt="CleanShot 2021-02-19 at 17 54 24@2x" src="https://user-images.githubusercontent.com/68148142/108488650-99487900-72db-11eb-8704-9a20b9d46fd5.png">
<img width="1388" alt="CleanShot 2021-02-19 at 17 54 37@2x" src="https://user-images.githubusercontent.com/68148142/108488636-9483c500-72db-11eb-9b60-d414fca4c685.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #197:
URL: https://github.com/apache/apisix-website/pull/197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#issuecomment-782519745
> > 
> > It seems broken?
>
> The team.md file doesn't have his GitHub username on it, I can't find his avatar.
OK, ignore this one currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#discussion_r579232839
##########
File path: website/src/assets/icons/eye.svg
##########
@@ -0,0 +1,4 @@
+<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M15 12a3 3 0 11-6 0 3 3 0 016 0z" />
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M2.458 12C3.732 7.943 7.523 5 12 5c4.478 0 8.268 2.943 9.542 7-1.274 4.057-5.064 7-9.542 7-4.477 0-8.268-2.943-9.542-7z" />
+</svg>
Review comment:
ditto
##########
File path: website/src/assets/icons/puzzle.svg
##########
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M11 4a2 2 0 114 0v1a1 1 0 001 1h3a1 1 0 011 1v3a1 1 0 01-1 1h-1a2 2 0 100 4h1a1 1 0 011 1v3a1 1 0 01-1 1h-3a1 1 0 01-1-1v-1a2 2 0 10-4 0v1a1 1 0 01-1 1H7a1 1 0 01-1-1v-3a1 1 0 00-1-1H4a2 2 0 110-4h1a1 1 0 001-1V7a1 1 0 011-1h3a1 1 0 001-1V4z" />
+</svg>
Review comment:
ditto
##########
File path: website/src/assets/icons/database.svg
##########
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M4 7v10c0 2.21 3.582 4 8 4s8-1.79 8-4V7M4 7c0 2.21 3.582 4 8 4s8-1.79 8-4M4 7c0-2.21 3.582-4 8-4s8 1.79 8 4m0 5c0 2.21-3.582 4-8 4s-8-1.79-8-4" />
+</svg>
Review comment:
ditto
##########
File path: website/src/pages/help.js
##########
@@ -1,6 +1,24 @@
const React = require("react");
import Layout from "@theme/Layout";
import ChevronRight from "../assets/icons/chevron-right.svg";
+import styled from "styled-components";
Review comment:
would better put this line before L4
##########
File path: website/src/assets/icons/code.svg
##########
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 20l4-16m4 4l4 4-4 4M6 16l-4-4 4-4" />
+</svg>
Review comment:
Please add a new line here
##########
File path: website/src/assets/icons/terminal.svg
##########
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M8 9l3 3-3 3m5 0h3M5 20h14a2 2 0 002-2V6a2 2 0 00-2-2H5a2 2 0 00-2 2v12a2 2 0 002 2z" />
+</svg>
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] qier222 commented on pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
qier222 commented on pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#issuecomment-782122514
> 
>
> It seems broken?
The team.md file doesn't have his GitHub username on it, I can't find his avatar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] qier222 commented on a change in pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
qier222 commented on a change in pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#discussion_r579590494
##########
File path: website/src/pages/team.js
##########
@@ -0,0 +1,326 @@
+import React from "react";
+import styled from "styled-components";
+import Layout from "@theme/Layout";
+import useDocusaurusContext from "@docusaurus/useDocusaurusContext";
+import GitHubLogo from "../assets/icons/github-logo.svg";
+
+import IconCode from "../assets/icons/code.svg";
+import IconStar from "../assets/icons/star.svg";
+import IconDatabase from "../assets/icons/database.svg";
+import IconTerminal from "../assets/icons/terminal.svg";
+import IconPuzzle from "../assets/icons/puzzle.svg";
+import IconEye from "../assets/icons/eye.svg";
+import IconDocumentText from "../assets/icons/document-text.svg";
+
+const PageTitle = styled.h1`
+ margin-top: 2rem;
+ font-size: 4rem;
+ font-weight: 800;
+ text-transform: uppercase;
+`;
+
+const PageSubtitle = styled.div`
+ margin-bottom: 3rem;
+`;
+
+const Page = styled.div`
+ max-width: var(--ifm-container-width);
+ margin: 0 auto;
+ padding: 2rem var(--ifm-spacing-horizontal);
+ width: 100%;
+`;
+
+const MembersContainer = styled.div`
+ display: grid;
+ grid-template-columns: repeat(6, 1fr);
+ gap: 18px;
+ @media (max-width: 812px) {
+ grid-template-columns: repeat(2, 1fr);
+ }
+`;
+const MemberCard = styled.a`
+ border-radius: 0.75rem;
+ border: 1px solid #eee;
+ box-shadow: 0 1px 2px 0 rgba(0, 0, 0, 0.03);
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ justify-content: center;
+ text-align: center;
+ padding: 1rem;
+ min-width: calc(108px + 2rem);
+ cursor: pointer;
+ height: 100%;
+ &:hover {
+ color: inherit;
+ text-decoration: none;
+ }
+`;
+
+const Avatar = styled.img`
+ height: 108px;
+ width: 108px;
+ border-radius: 50%;
+`;
+const MemberName = styled.div`
+ font-size: 1rem;
+ font-weight: 600;
+ margin-top: 12px;
+ margin-bottom: -4px;
+ line-height: 1rem;
+`;
+const Username = styled.div`
+ font-size: 12px;
Review comment:
Use `rem` is indeed a better option, I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#issuecomment-782119991
> @juzhiyuan Do we need to sort the list alphabetically? It seems at first the PMC list is sort in that way but later it goes chronologically 🤣
Ya, would better do that. We could do it in another PR if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#issuecomment-782031859
@juzhiyuan Do we need to sort the list alphabetically? It seems at first the PMC list is sort in that way but later it goes chronologically 🤣
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#discussion_r579585434
##########
File path: website/src/pages/team.js
##########
@@ -0,0 +1,326 @@
+import React from "react";
+import styled from "styled-components";
+import Layout from "@theme/Layout";
+import useDocusaurusContext from "@docusaurus/useDocusaurusContext";
+import GitHubLogo from "../assets/icons/github-logo.svg";
+
+import IconCode from "../assets/icons/code.svg";
+import IconStar from "../assets/icons/star.svg";
+import IconDatabase from "../assets/icons/database.svg";
+import IconTerminal from "../assets/icons/terminal.svg";
+import IconPuzzle from "../assets/icons/puzzle.svg";
+import IconEye from "../assets/icons/eye.svg";
+import IconDocumentText from "../assets/icons/document-text.svg";
+
+const PageTitle = styled.h1`
+ margin-top: 2rem;
+ font-size: 4rem;
+ font-weight: 800;
+ text-transform: uppercase;
+`;
+
+const PageSubtitle = styled.div`
+ margin-bottom: 3rem;
+`;
+
+const Page = styled.div`
+ max-width: var(--ifm-container-width);
+ margin: 0 auto;
+ padding: 2rem var(--ifm-spacing-horizontal);
+ width: 100%;
+`;
+
+const MembersContainer = styled.div`
+ display: grid;
+ grid-template-columns: repeat(6, 1fr);
+ gap: 18px;
+ @media (max-width: 812px) {
+ grid-template-columns: repeat(2, 1fr);
+ }
+`;
+const MemberCard = styled.a`
+ border-radius: 0.75rem;
+ border: 1px solid #eee;
+ box-shadow: 0 1px 2px 0 rgba(0, 0, 0, 0.03);
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ justify-content: center;
+ text-align: center;
+ padding: 1rem;
+ min-width: calc(108px + 2rem);
+ cursor: pointer;
+ height: 100%;
+ &:hover {
+ color: inherit;
+ text-decoration: none;
+ }
+`;
+
+const Avatar = styled.img`
+ height: 108px;
+ width: 108px;
+ border-radius: 50%;
+`;
+const MemberName = styled.div`
+ font-size: 1rem;
+ font-weight: 600;
+ margin-top: 12px;
+ margin-bottom: -4px;
+ line-height: 1rem;
+`;
+const Username = styled.div`
+ font-size: 12px;
Review comment:
May I ask why not use `rem` here? `rem` would be more friendly to fit different display devices
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#issuecomment-782119788
It seems broken?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] qier222 commented on a change in pull request #197: style: redesign team page
Posted by GitBox <gi...@apache.org>.
qier222 commented on a change in pull request #197:
URL: https://github.com/apache/apisix-website/pull/197#discussion_r579244114
##########
File path: website/src/pages/help.js
##########
@@ -1,6 +1,24 @@
const React = require("react");
import Layout from "@theme/Layout";
import ChevronRight from "../assets/icons/chevron-right.svg";
+import styled from "styled-components";
Review comment:
all fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org