[jira] [Updated] (LUCENE-5958) OOM or exceptions during checkpoint make IndexWriter have a bad day

["Robert Muir (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-5958:
--------------------------------
    Attachment: LUCENE-5958.patch

Here's a first stab: when we hit 'unrecoverable exception' like this, we record the exception (instead of hitOOM), close ourselves. In such a "screwed" state IndexFileDeleter also refuses to delete any files so we wont corrupt anything.

This is better on the user i think, because previously they had to do this OOM handling themselves, but now IW will throw ACE (with root cause of why it had to do this) on any future operation.


> OOM or exceptions during checkpoint make IndexWriter have a bad day
> -------------------------------------------------------------------
>
>                 Key: LUCENE-5958
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5958
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5958.patch
>
>
> During finishCommit(), we run checkpoint after we wrote the commit to disk, but if things go wrong here (e.g. IOError when IFD deletes a pending file, OOM), then everything will go wrong (we won't even properly incref things, and may end out deleting wrong files if the user calls rollback, leaving a corrupt index).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org