You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Andrew Grieve (JIRA)" <ji...@apache.org> on 2013/06/21 04:01:23 UTC

[jira] [Commented] (CB-3954) jsmodule name attribute can't be reused in plugin.xml

    [ https://issues.apache.org/jira/browse/CB-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689966#comment-13689966 ] 

Andrew Grieve commented on CB-3954:
-----------------------------------

For modules that use clobbers / merges, it'd be nice if name wasn't required. It's unlikely that the user would need to cordova.require() it. Plugman could just assign it a unique name.
                
> jsmodule name attribute can't be reused in plugin.xml
> -----------------------------------------------------
>
>                 Key: CB-3954
>                 URL: https://issues.apache.org/jira/browse/CB-3954
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>            Reporter: Steve Gill
>            Assignee: Filip Maj
>            Priority: Minor
>
> Not sure if bug or intended. For the file plugin (and some other plugins), platform specific js exists. In file's case, two entry.js files exist. One is in common, and one is ios specific. The ios one is supposed to merge into the common one. Jsmodules support merging. These are the two jsmodule blocks I am working with.
> <js-module src="www/Entry.js" name="Entry">
>     <clobbers target="window.Entry" />
> </js-module> 
> This one is nested in the ios platform tag
> <js-module src="www/ios/Entry.js" name="Entry">
>     <merges target="window.Entry" />
> </js-module>
> The ios specific JS does not merge in this case. To fix this, I just had to change the name attribute on the ios specific jsmodule call. I changed it to Entry1 instead of Entry. This does the trick. 
> This is probably not a bug, but people might run into it. I suggest adding it to the docs?
> Thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira