Miss behaving functions in Synapse

[Ruwan Linton <ru...@gmail.com>]

Hi,

I have came accros the following misbehaving in the EndpointSerializer
class.

   public static void serializeEndpoint(Endpoint endpt, OMElement parent) {

        OMElement endpoint = fac.createOMElement("endpoint", synNS);
        if (endpt.getAddress() != null) {
            endpoint.addAttribute(fac.createOMAttribute(
                "address", nullNS, endpt.getAddress().toString()));
        } else {
            handleException("Invalid Endpoint. Address is required");
        }

        // TODO handle advanced options

        if (parent != null) {
            parent.addChild(endpoint);
        }
    }

Although this method is a get method it dosent return anything (void), in
the implementation it declares an OMElement but doesnt return it.

I will put patch to correct this with a jira. Can someone apply that patch
please.

Thanks,
Ruwan.

Re: Miss behaving functions in Synapse

["Asankha C. Perera" <as...@wso2.com>]

Ruwan

Yes.. the Serialization classes may have a few issues, as Synapse 
doesn't really invoke them directly (yet!). I will apply the patch :-)

thanks
asankha

Ruwan Linton wrote:
> Hi,
>
> I have came accros the following misbehaving in the EndpointSerializer 
> class.
>
>    public static void serializeEndpoint(Endpoint endpt, OMElement 
> parent) {
>
>         OMElement endpoint = fac.createOMElement ("endpoint", synNS);
>         if (endpt.getAddress() != null) {
>             endpoint.addAttribute(fac.createOMAttribute(
>                 "address", nullNS, endpt.getAddress().toString()));
>         } else {
>             handleException("Invalid Endpoint. Address is required");
>         }
>
>         // TODO handle advanced options
>
>         if (parent != null) {
>             parent.addChild(endpoint);
>         }
>     }
>
> Although this method is a get method it dosent return anything (void), 
> in the implementation it declares an OMElement but doesnt return it.
>
> I will put patch to correct this with a jira. Can someone apply that 
> patch please.
>
> Thanks,
> Ruwan.


---------------------------------------------------------------------
To unsubscribe, e-mail: synapse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: synapse-dev-help@ws.apache.org