You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Zoltan Haindrich <ki...@rxd.hu> on 2017/03/13 19:56:21 UTC
Review Request 57568: HIVE-15978 Support regr_* functions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57568/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-15978
https://issues.apache.org/jira/browse/HIVE-15978
Repository: hive-git
Description
-------
all aggregators have been implemented by using some existing aggregator
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4ac25c24eb1becf1640d35f5b79965e4aefc5421
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDAFBinarySetFunctions.java PRE-CREATION
ql/src/test/queries/clientpositive/udaf_binarysetfunctions.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 1361b9322199bbee5a97b402253e204004bcbfb9
ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/57568/diff/1/
Testing
-------
Thanks,
Zoltan Haindrich
Re: Review Request 57568: HIVE-15978 Support regr_* functions
Posted by Zoltan Haindrich <ki...@rxd.hu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57568/
-----------------------------------------------------------
(Updated March 15, 2017, 12:52 a.m.)
Review request for hive.
Changes
-------
use decimal averaging aggregator in avgx/avgy
Bugs: HIVE-15978
https://issues.apache.org/jira/browse/HIVE-15978
Repository: hive-git
Description
-------
all aggregators have been implemented by using some existing aggregator
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4ac25c24eb1becf1640d35f5b79965e4aefc5421
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDAFBinarySetFunctions.java PRE-CREATION
ql/src/test/queries/clientpositive/udaf_binarysetfunctions.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 1361b9322199bbee5a97b402253e204004bcbfb9
ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/57568/diff/2/
Changes: https://reviews.apache.org/r/57568/diff/1-2/
Testing
-------
Thanks,
Zoltan Haindrich
Re: Review Request 57568: HIVE-15978 Support regr_* functions
Posted by Zoltan Haindrich <ki...@rxd.hu>.
> On March 14, 2017, 11:08 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
> > Lines 211 (patched)
> > <https://reviews.apache.org/r/57568/diff/1/?file=1662842#file1662842line211>
> >
> > We can instantiate GenericUDAFAverageEvaluatorDecimal by looking at arguments.
i've fixed this
> On March 14, 2017, 11:08 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
> > Lines 255 (patched)
> > <https://reviews.apache.org/r/57568/diff/1/?file=1662842#file1662842line255>
> >
> > This implies we can't use corr, correct. This function is not symmetric. We need to be standard compliant.
not entirely...corr works as it should - and its great...the only problem with it is that it lists the arguments in twisted order: i've opened a separate ticket(HIVE-16178) to address this - that change will eliminate these comments too.
i've put the note here because the field names in the correlation evaluator are also twisted; that's why I used x when the function name have implied y ; HIVE-16178 will fix this problem
> On March 14, 2017, 11:08 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out
> > Lines 399 (patched)
> > <https://reviews.apache.org/r/57568/diff/1/?file=1662846#file1662846line399>
> >
> > Testing on postgres, got NULL for covar_samp() instead of 0.0
hive will start giving the correct answer for this case after HIVE-16178 - because that is different change; I did't wanted to mix it into this one; but it seemed right to run all the binary set functions in this test for completeness.
- Zoltan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57568/#review168950
-----------------------------------------------------------
On March 13, 2017, 7:56 p.m., Zoltan Haindrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57568/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 7:56 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-15978
> https://issues.apache.org/jira/browse/HIVE-15978
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> all aggregators have been implemented by using some existing aggregator
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4ac25c24eb1becf1640d35f5b79965e4aefc5421
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDAFBinarySetFunctions.java PRE-CREATION
> ql/src/test/queries/clientpositive/udaf_binarysetfunctions.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out 1361b9322199bbee5a97b402253e204004bcbfb9
> ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57568/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zoltan Haindrich
>
>
Re: Review Request 57568: HIVE-15978 Support regr_* functions
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57568/#review168950
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 211 (patched)
<https://reviews.apache.org/r/57568/#comment241265>
We can instantiate GenericUDAFAverageEvaluatorDecimal by looking at arguments.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 215 (patched)
<https://reviews.apache.org/r/57568/#comment241267>
See above. Any reason for not supporting decimal?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 255 (patched)
<https://reviews.apache.org/r/57568/#comment241268>
This implies we can't use corr, correct. This function is not symmetric. We need to be standard compliant.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java
Lines 289 (patched)
<https://reviews.apache.org/r/57568/#comment241269>
Cant use correvaluator then.
ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out
Lines 399 (patched)
<https://reviews.apache.org/r/57568/#comment241272>
Testing on postgres, got NULL for covar_samp() instead of 0.0
- Ashutosh Chauhan
On March 13, 2017, 7:56 p.m., Zoltan Haindrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57568/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 7:56 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-15978
> https://issues.apache.org/jira/browse/HIVE-15978
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> all aggregators have been implemented by using some existing aggregator
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4ac25c24eb1becf1640d35f5b79965e4aefc5421
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFBinarySetFunctions.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDAFBinarySetFunctions.java PRE-CREATION
> ql/src/test/queries/clientpositive/udaf_binarysetfunctions.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out 1361b9322199bbee5a97b402253e204004bcbfb9
> ql/src/test/results/clientpositive/udaf_binarysetfunctions.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57568/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zoltan Haindrich
>
>