[GitHub] [superset] eschutho commented on a change in pull request #15057: feat: style import button

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #15057:
URL: https://github.com/apache/superset/pull/15057#discussion_r648532378



##########
File path: superset-frontend/src/components/ImportModal/index.tsx
##########
@@ -16,10 +16,13 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React, { FunctionComponent, useEffect, useRef, useState } from 'react';
+import React, { FunctionComponent, useEffect, useState } from 'react';
+import { Upload } from 'antd';

Review comment:
       A few of us were just talking about antd imports the other day. Do you mind importing and exporting this component in the /superset-frontend/src/common/components/index.tsx file and pulling it in from there? We're going to try to clean all these up at some point for consistency. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org