You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/23 03:13:38 UTC
[GitHub] [incubator-kvrocks] shangxiaoxiong opened a new pull request, #913: Customize prefix extractor for subkey
shangxiaoxiong opened a new pull request, #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913
Customize prefix extractor for subkey. Range query prefermance is likely improved when applying this prefix extractor to subkey column family.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #913: Customize prefix extractor for subkey
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1480612441
Hi @shangxiaoxiong , do you still have time to continue this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
torwig commented on code in PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#discussion_r980304952
##########
src/prefix_extractor.h:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+#pragma once
+
+#include <rocksdb/slice_transform.h>
+
+class SubkeyPrefixTransform : public rocksdb::SliceTransform {
+ private:
+ bool cluster_enabled_;
+ uint8_t prefix_base_len_;
+
+ public:
+ explicit SubkeyPrefixTransform(bool cluster_enabled) : cluster_enabled_(cluster_enabled) {
+ // Subkey format:
+ // 1(namespace_len) + N(namespace) + 2(slot_id) + 4(user_key_len) + N(user_key) + 8(version) + N(field) + ..
+ // If cluster_enabled is true, length of Subkey is not smaller than 15
+ // If cluster_enabled is false, length of Subkey is not smaller than 13
+ prefix_base_len_ = cluster_enabled ? 15 : 13;
+ }
+
+ const char* Name() const override { return "Kvrocks.SubkeyPrefix"; }
+
+ rocksdb::Slice Transform(const rocksdb::Slice& src) const override {
Review Comment:
Tiny fix: please move `&` from the type name to the `src` variable. Both in the `.h` file and the `.cc` file, other functions as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on a diff in pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on code in PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#discussion_r978346540
##########
src/prefix_extractor.h:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+#pragma once
+
+#include <rocksdb/slice_transform.h>
+
+class SubkeyPrefixTransform : public rocksdb::SliceTransform {
+ private:
+ bool cluster_enabled_;
+ uint8_t prefix_base_len_;
+
+ public:
+ explicit SubkeyPrefixTransform(bool cluster_enabled) : cluster_enabled_(cluster_enabled) {
+ // Subkey format:
+ // 1(namespace_len) + N(namespace) + 2(slot_id) + 4(user_key_len) + N(user_key) + 8(version) + N(field) + ..
+ // If cluster_enabled is true, length of Subkey is not smaller than 15
+ // If cluster_enabled is false, length of Subkey is not smaller than 13
+ prefix_base_len_ = cluster_enabled ? 15 : 13;
+ }
+
+ const char* Name() const override { return "Kvrocks.SubkeyPrefix"; }
+
+ rocksdb::Slice Transform(const rocksdb::Slice& src) const override {
+ assert(InDomain(src));
+ size_t prefix_len = GetPrefixLen(src);
+ return rocksdb::Slice(src.data(), prefix_len);
+ }
+
+ bool InDomain(const rocksdb::Slice& src) const override {
+ return (src.size() >= prefix_base_len_);
+ }
+
+ size_t GetPrefixLen(const rocksdb::Slice& input) const;
+};
+
+extern const rocksdb::SliceTransform* NewSubkeyPrefixTransform(bool cluster_enabled);
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255810315
@shangxiaoxiong So I think we can merge what #508 does into this PR and use the new prefix extractor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255803155
@shangxiaoxiong I didn't see where's using this prefix extractor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255875731
@caipengbo is right, we can add more informations to make this easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #913: Customize prefix extractor for subkey
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1494126736
I will raise another PR to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] caipengbo commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
caipengbo commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255854726
Thank you for your contribution, it would be better if you could explain it in detail in this PR, which can help us to see the code and understand the design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] caipengbo commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
caipengbo commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255759803
Cool！How much performance improvement did you get from testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255812880
> @shangxiaoxiong So I think we can merge what #508 does into this PR and use the new prefix extractor.
l think so and l can merge https://github.com/apache/incubator-kvrocks/pull/508 if there is no problem about the new prefix extractor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255859583
> Thank you for your contribution, it would be better if you could explain it in detail in this PR, which can help us to see the code and understand the design.
Don't make me hammer you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255877387
> @caipengbo is right, we can add more informations to make this easier to review.
ha ha ha ! On the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1306844001
Hi @shangxiaoxiong! Any progress on this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on a diff in pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on code in PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#discussion_r978346979
##########
src/prefix_extractor.h:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+#pragma once
+
+#include <rocksdb/slice_transform.h>
+
+class SubkeyPrefixTransform : public rocksdb::SliceTransform {
+ private:
+ bool cluster_enabled_;
+ uint8_t prefix_base_len_;
+
+ public:
+ explicit SubkeyPrefixTransform(bool cluster_enabled) : cluster_enabled_(cluster_enabled) {
+ // Subkey format:
+ // 1(namespace_len) + N(namespace) + 2(slot_id) + 4(user_key_len) + N(user_key) + 8(version) + N(field) + ..
+ // If cluster_enabled is true, length of Subkey is not smaller than 15
+ // If cluster_enabled is false, length of Subkey is not smaller than 13
+ prefix_base_len_ = cluster_enabled ? 15 : 13;
+ }
+
+ const char* Name() const override { return "Kvrocks.SubkeyPrefix"; }
+
+ rocksdb::Slice Transform(const rocksdb::Slice& src) const override {
+ assert(InDomain(src));
+ size_t prefix_len = GetPrefixLen(src);
+ return rocksdb::Slice(src.data(), prefix_len);
+ }
+
+ bool InDomain(const rocksdb::Slice& src) const override {
+ return (src.size() >= prefix_base_len_);
+ }
+
+ size_t GetPrefixLen(const rocksdb::Slice& input) const;
+};
+
+extern const rocksdb::SliceTransform* NewSubkeyPrefixTransform(bool cluster_enabled);
Review Comment:
> I think, if you defined this function, you can move the definition of `class SubkeyPrefixTransform` to the source file `prefix_extractor.cc`. Or you can just remove this function.
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1259028188
> @shangxiaoxiong You can help to pull the @ShooterIT's PR into this, then we can pull others to have a look again.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #913: Customize prefix extractor for subkey
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1486583998
@PragmaTwice I will continue working on this and also #508 recently if @shangxiaoxiong and @ShooterIT don't have time to move on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255813763
Got it, thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1259027799
>
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255763614
l did an incomplete test. For 1 millon times short range query, the query time is reduced more than 20%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#discussion_r978338376
##########
src/prefix_extractor.h:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+#pragma once
+
+#include <rocksdb/slice_transform.h>
+
+class SubkeyPrefixTransform : public rocksdb::SliceTransform {
+ private:
+ bool cluster_enabled_;
+ uint8_t prefix_base_len_;
+
+ public:
+ explicit SubkeyPrefixTransform(bool cluster_enabled) : cluster_enabled_(cluster_enabled) {
+ // Subkey format:
+ // 1(namespace_len) + N(namespace) + 2(slot_id) + 4(user_key_len) + N(user_key) + 8(version) + N(field) + ..
+ // If cluster_enabled is true, length of Subkey is not smaller than 15
+ // If cluster_enabled is false, length of Subkey is not smaller than 13
+ prefix_base_len_ = cluster_enabled ? 15 : 13;
+ }
+
+ const char* Name() const override { return "Kvrocks.SubkeyPrefix"; }
+
+ rocksdb::Slice Transform(const rocksdb::Slice& src) const override {
+ assert(InDomain(src));
+ size_t prefix_len = GetPrefixLen(src);
+ return rocksdb::Slice(src.data(), prefix_len);
+ }
+
+ bool InDomain(const rocksdb::Slice& src) const override {
+ return (src.size() >= prefix_base_len_);
+ }
+
+ size_t GetPrefixLen(const rocksdb::Slice& input) const;
+};
+
+extern const rocksdb::SliceTransform* NewSubkeyPrefixTransform(bool cluster_enabled);
Review Comment:
I think, if you defined this function, you can move the definition of `class SubkeyPrefixTransform` to the source file `prefix_extractor.cc`. Or you can just remove this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] shangxiaoxiong commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
shangxiaoxiong commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1255805940
https://github.com/apache/incubator-kvrocks/pull/508 shows the usage of prefix extracor (FixedPrefixTransform provided by Rocksdb) @git-hulk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #913: Customize prefix extractor for subkey
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #913:
URL: https://github.com/apache/incubator-kvrocks/pull/913#issuecomment-1258262707
@shangxiaoxiong You can help to pull the @ShooterIT's PR into this, then we can pull others to have a look a again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk closed pull request #913: Customize prefix extractor for subkey
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed pull request #913: Customize prefix extractor for subkey
URL: https://github.com/apache/incubator-kvrocks/pull/913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org