You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/04/08 16:34:51 UTC
Re: Review Request 42241: Speed up
HookTest.VerifySlaveLaunchExecutorHook.
> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote:
> > src/tests/hook_tests.cpp, line 396
> > <https://reviews.apache.org/r/42241/diff/3/?file=1200496#file1200496line396>
> >
> > Is there a need to explicitly invoke `Clock::resume()` here? If not, kill it.
Let's leave the test with resumed clock for consistency.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42241/#review119797
-----------------------------------------------------------
On Feb. 19, 2016, 4:36 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42241/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 4:36 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Timothy Chen.
>
>
> Bugs: MESOS-4174
> https://issues.apache.org/jira/browse/MESOS-4174
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up HookTest.VerifySlaveLaunchExecutorHook.
>
>
> Diffs
> -----
>
> src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9
>
> Diff: https://reviews.apache.org/r/42241/diff/
>
>
> Testing
> -------
>
> Before
> HookTest.VerifySlaveLaunchExecutorHook (5061 ms)
>
> After
> HookTest.VerifySlaveLaunchExecutorHook (132 ms)
>
>
> Thanks,
>
> Jian Qiu
>
>