You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/22 14:59:13 UTC

[GitHub] [mynewt-mcumgr] de-nordic commented on a change in pull request #115: Support for software update to Direct-XIP built applications

de-nordic commented on a change in pull request #115:
URL: https://github.com/apache/mynewt-mcumgr/pull/115#discussion_r580316387



##########
File path: cmd/img_mgmt/include/img_mgmt/img_mgmt_config.h
##########
@@ -32,13 +32,41 @@
 
 #elif defined __ZEPHYR__
 
+#include <devicetree.h>
+
 #define IMG_MGMT_UL_CHUNK_SIZE  CONFIG_IMG_MGMT_UL_CHUNK_SIZE
 #define IMG_MGMT_VERBOSE_ERR    CONFIG_IMG_MGMT_VERBOSE_ERR
 #define IMG_MGMT_LAZY_ERASE     CONFIG_IMG_ERASE_PROGRESSIVELY
 #define IMG_MGMT_DUMMY_HDR      CONFIG_IMG_MGMT_DUMMY_HDR
-#define IMG_MGMT_BOOT_CURR_SLOT 0
 
+#define DT_CODE_PARTITION_NODE DT_CHOSEN(zephyr_code_partition)

Review comment:
       You mean that it should be in separate header taken directly from Zrephyr code base?
   I was also thinking about that and that is one of reasons behind https://github.com/zephyrproject-rtos/zephyr/issues/32257




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org