[GitHub] [hudi] prashantwason commented on a change in pull request #2128: [HUDI-1303] Some improvements for the HUDI Test Suite.

[GitBox <gi...@apache.org>]

prashantwason commented on a change in pull request #2128:
URL: https://github.com/apache/hudi/pull/2128#discussion_r499825998



##########
File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/generator/GenericRecordFullPayloadGenerator.java
##########
@@ -205,45 +193,36 @@ private Object typeConvert(Schema schema) {
       case LONG:
         return getNextConstrainedLong();
       case STRING:
-        return UUID.randomUUID().toString();
+       return UUID.randomUUID().toString();
       case ENUM:
-        List<String> enumSymbols = localSchema.getEnumSymbols();
-        return new GenericData.EnumSymbol(localSchema, enumSymbols.get(random.nextInt(enumSymbols.size() - 1)));
+        List<String> enumSymbols = fieldSchema.getEnumSymbols();
+        return new GenericData.EnumSymbol(fieldSchema, enumSymbols.get(random.nextInt(enumSymbols.size() - 1)));
       case RECORD:
-        return convert(localSchema);
+        return getNewPayload(fieldSchema);
       case ARRAY:
-        Schema elementSchema = localSchema.getElementType();
+        Schema.Field elementField = new Schema.Field(field.name(), fieldSchema.getElementType(), "", null);
         List listRes = new ArrayList();
-        if (isPrimitive(elementSchema) && this.shouldAddMore) {
-          int numEntriesToAdd = numEntriesToAdd(elementSchema);
-          while (numEntriesToAdd > 0) {
-            listRes.add(typeConvert(elementSchema));
-            numEntriesToAdd--;
-          }
-        } else {
-          listRes.add(typeConvert(elementSchema));
+        int numEntriesToAdd = extraEntriesMap.getOrDefault(field.name(), 1);
+        while (numEntriesToAdd > 0) {

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org