You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "adb014 (via GitHub)" <gi...@apache.org> on 2026/06/01 14:11:23 UTC

[PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

adb014 opened a new pull request, #1217:
URL: https://github.com/apache/guacamole-client/pull/1217

   This is a rebase and a completion of the PR #1062.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on code in PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#discussion_r3339713193


##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -381,8 +381,8 @@
         "DIALOG_HEADER_CONFIRM_DELETE" : "Supprimer le Profil de Partage",
         "DIALOG_HEADER_ERROR" : "@:APP.DIALOG_HEADER_ERROR",
 
-        "FIELD_HEADER_NAME" : "Nom:",
-        "FIELD_HEADER_PRIMARY_CONNECTION" : "Connexion Primaire:",
+        "FIELD_HEADER_NAME" : "Nom: ",

Review Comment:
   `"Nom\u202F:"`



##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -1158,10 +1160,10 @@
 
      "USER_ATTRIBUTES" : {
 
-        "FIELD_HEADER_GUAC_EMAIL_ADDRESS"       : "Adresse Mail:",
-        "FIELD_HEADER_GUAC_FULL_NAME"           : "Nom:",
-        "FIELD_HEADER_GUAC_ORGANIZATION"        : "Organisation:",
-        "FIELD_HEADER_GUAC_ORGANIZATIONAL_ROLE" : "Rôle:"
+        "FIELD_HEADER_GUAC_EMAIL_ADDRESS"       : "Adresse Mail\u202F:",
+        "FIELD_HEADER_GUAC_FULL_NAME"           : "Nom\u202F:",
+        "FIELD_HEADER_GUAC_ORGANIZATION"        : "Organisation\u202F:",
+        "FIELD_HEADER_GUAC_ORGANIZATIONAL_ROLE" : "Rôle\u202F:",

Review Comment:
   This comma breaks the JSON.



##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -183,7 +183,7 @@
 
         "FIELD_OPTION_CUSTOM" : "Personnaliser...",
 
-        "SECTION_HEADER_DETAILS" : "Détails:"
+        "SECTION_HEADER_DETAILS" : "Détails\u202F:",

Review Comment:
   This comma breaks the JSON.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4742411909

   Ah, ok I thnk I misunderstood, you want to keep @YAGA29's commit as is and squash might... Ok, on it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4594773478

   > > I agree about the translations themselves.
   > > Is there a specific reason for putting `main` in the base branch rather than `staging/1.6.1` (next version)?
   > 
   > Well mainly 'cause I'm new to Guacamole development (though I've been a user for a while) and have no real idea of the release process. This is the same with my other PR, they are all against "main". Where is the appropriate place to base this PR and my other PR ? Does the same logique apply to [guacamole-manual](https://issues.apache.org/jira/browse/GUACAMOLE-manual) ?
   
   Ok I rebased my branch and updated the pull request to staging/1.61


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4742235894

   I think you could keep the message from the first commit as it is in #1118 (`GUACAMOLE-2034 : Fix few typos, missing translation and formatting issues in french fr.json`) and squash the latest commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4594394714

   > I agree about the translations themselves.
   > 
   > Is there a specific reason for putting `main` in the base branch rather than `staging/1.6.1` (next version)?
   
   Well mainly 'cause I'm new to Guacamole development (though I've been a user for a while) and have no real idea of the release process. This is the same with my other PR, they are all against "main". Where is the appropriate place to base this PR and my other PR ? Does the same logique apply to guacamole-manual ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on code in PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#discussion_r3335335083


##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -40,10 +40,10 @@
         "ERROR_PASSWORD_MISMATCH" : "Le mot de passe ne correspond pas.",
         "ERROR_SINGLE_FILE_ONLY"  : "Veuillez télécharger un seul fichier à la fois.",
 
-        "FIELD_HEADER_PASSWORD"       : "Mot de passe:",
-        "FIELD_HEADER_PASSWORD_AGAIN" : "Répéter mot de passe:",
-        "FIELD_HEADER_RECORDING_WRITE_EXISTING"  : "Autoriser l'écriture dans le fichier d'enregistrement existant:",
-        "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Autoriser l'écriture dans le fichier TypeScript existant:",
+        "FIELD_HEADER_PASSWORD"       : "Mot de passe : ",

Review Comment:
   The space before the two dots does not appear to be a non-breaking space.
   ```bash
   [root@localhost guacamole-client]# sed -n '44p' guacamole/src/main/frontend/src/translations/fr.json | xxd
   00000000: 2020 2020 2020 2020 2246 4945 4c44 5f48          "FIELD_H
   00000010: 4541 4445 525f 5041 5353 574f 5244 5f41  EADER_PASSWORD_A
   00000020: 4741 494e 2220 3a20 2252 c3a9 70c3 a974  GAIN" : "R..p..t
   00000030: 6572 206d 6f74 2064 6520 7061 7373 6520  er mot de passe 
   00000040: 3a20 222c 0a                             : ",.
   ```
   
   From what I saw in the other PR, `\u00a0` doesn't work, but maybe we can just put the character in as is?
   
   Also, I wonder if it's really relevant to put a space after the colon at the end of the sentence since there's no text after it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 closed pull request #1217: GUACAMOLE-2034: Update fr.json (rebase and complete)
URL: https://github.com/apache/guacamole-client/pull/1217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4593451714

   For information with a bit of vibe coding and horrible hacks, I tried using Argos Translate for this translation (and in fact all of the missing translation strings) The script is [translate_missing2.py](https://github.com/user-attachments/files/28468360/translate_missing2.py). It kind of worked with some layout and  translation errors particularly for short phrases or where more context was needed to allow translation of an isolation sentence, otherwise it worked pretty well.
   
   A note this here for reference is someone else want to attack translate strings and they are get a basis for the translation with my script from Argos Translate (PS it does need to download almost 15 GB of data for the language models of all the languages supportted by Guacamole) 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4604810087

   > > I agree about the translations themselves.
   > > Is there a specific reason for putting `main` in the base branch rather than `staging/1.6.1` (next version)?
   > 
   > Well mainly 'cause I'm new to Guacamole development (though I've been a user for a while) and have no real idea of the release process. This is the same with my other PR, they are all against "main". Where is the appropriate place to base this PR and my other PR ? Does the same logic apply to [guacamole-manual](https://issues.apache.org/jira/browse/GUACAMOLE-manual) ?
   
   Our Confluence page has some more details on branching and how we do versioning within Guacamole:
   
   https://cwiki.apache.org/confluence/display/GUAC/Version+Numbering+and+Branching+Scheme
   
   That may help to clear some of it up. We're trying to close out for the 1.6.1 release, and squeezing the last few things in there, so Corentin was just adding this one to the growing list of fixes that go into 1.6.1, since it's very much a fix. One of these days we'll actually finish that release...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4600367631

   > > I agree about the translations themselves.
   > > Is there a specific reason for putting `main` in the base branch rather than `staging/1.6.1` (next version)?
   > 
   > Well mainly 'cause I'm new to Guacamole development (though I've been a user for a while) and have no real idea of the release process. This is the same with my other PR, they are all against "main". Where is the appropriate place to base this PR and my other PR ? Does the same logic apply to [guacamole-manual](https://issues.apache.org/jira/browse/GUACAMOLE-manual) ?
   
   The main branch contains features for an upcoming 1.7.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4605210602

   > > > I agree about the translations themselves.
   > > > Is there a specific reason for putting `main` in the base branch rather than `staging/1.6.1` (next version)?
   > > 
   > > 
   > > Well mainly 'cause I'm new to Guacamole development (though I've been a user for a while) and have no real idea of the release process. This is the same with my other PR, they are all against "main". Where is the appropriate place to base this PR and my other PR ? Does the same logic apply to [guacamole-manual](https://issues.apache.org/jira/browse/GUACAMOLE-manual) ?
   > 
   > Our Confluence page has some more details on branching and how we do versioning within Guacamole:
   > 
   > https://cwiki.apache.org/confluence/display/GUAC/Version+Numbering+and+Branching+Scheme
   > 
   > That may help to clear some of it up. We're trying to close out for the 1.6.1 release, and squeezing the last few things in there, so Corentin was just adding this one to the growing list of fixes that go into 1.6.1, since it's very much a fix. One of these days we'll actually finish that release...
   
   Ok so if I understand looking at my 3 current contributions and their corresponding contributions to guacamole-manual, if 1.6.2 is coming soon, you want the following 
   
   #1217 -> staging/1.6.1
   #1216 -> main targeting 1.7.0
   #1198 -> probably main but maybe staging/1.6.1 if you think the change isn’t that major 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#issuecomment-4742386696

   > I think you could keep the message from the first commit as it is in #1118 (`GUACAMOLE-2034 : Fix few typos, missing translation and formatting issues in french fr.json`) and squash the latest commit.
   
   Ok, no problem, but what to do with the "Author" line of the commit ? With at least two commits I don't appear as the author of the modifications proposed by @YAGA29, and he doesn't appears as the author of mine.. Squashing to a single commit and only one of us is the Author


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "adb014 (via GitHub)" <gi...@apache.org>.
adb014 commented on code in PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#discussion_r3335546085


##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -40,10 +40,10 @@
         "ERROR_PASSWORD_MISMATCH" : "Le mot de passe ne correspond pas.",
         "ERROR_SINGLE_FILE_ONLY"  : "Veuillez télécharger un seul fichier à la fois.",
 
-        "FIELD_HEADER_PASSWORD"       : "Mot de passe:",
-        "FIELD_HEADER_PASSWORD_AGAIN" : "Répéter mot de passe:",
-        "FIELD_HEADER_RECORDING_WRITE_EXISTING"  : "Autoriser l'écriture dans le fichier d'enregistrement existant:",
-        "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Autoriser l'écriture dans le fichier TypeScript existant:",
+        "FIELD_HEADER_PASSWORD"       : "Mot de passe : ",

Review Comment:
   I replaced " : " with "\u202F:" everywhere as in #1118, The information was spread over two different PR, sorry I initially missed this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-2034: Update fr.json (rebase and complete) [guacamole-client]

Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on code in PR #1217:
URL: https://github.com/apache/guacamole-client/pull/1217#discussion_r3335335083


##########
guacamole/src/main/frontend/src/translations/fr.json:
##########
@@ -40,10 +40,10 @@
         "ERROR_PASSWORD_MISMATCH" : "Le mot de passe ne correspond pas.",
         "ERROR_SINGLE_FILE_ONLY"  : "Veuillez télécharger un seul fichier à la fois.",
 
-        "FIELD_HEADER_PASSWORD"       : "Mot de passe:",
-        "FIELD_HEADER_PASSWORD_AGAIN" : "Répéter mot de passe:",
-        "FIELD_HEADER_RECORDING_WRITE_EXISTING"  : "Autoriser l'écriture dans le fichier d'enregistrement existant:",
-        "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Autoriser l'écriture dans le fichier TypeScript existant:",
+        "FIELD_HEADER_PASSWORD"       : "Mot de passe : ",

Review Comment:
   The space before the two dots does not appear to be a non-breaking space.
   ```bash
   [root@localhost guacamole-client]# sed -n '44p' guacamole/src/main/frontend/src/translations/fr.json | xxd
   00000000: 2020 2020 2020 2020 2246 4945 4c44 5f48          "FIELD_H
   00000010: 4541 4445 525f 5041 5353 574f 5244 5f41  EADER_PASSWORD_A
   00000020: 4741 494e 2220 3a20 2252 c3a9 70c3 a974  GAIN" : "R..p..t
   00000030: 6572 206d 6f74 2064 6520 7061 7373 6520  er mot de passe 
   00000040: 3a20 222c 0a                             : ",.
   ```
   
   From what I saw in the other PR, `\u00a0` doesn't work, but maybe we can just put the character in as is?
   
   Also, I wonder if it's really relevant to put a space after the colon at the end of the sentence since there's no text after it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org