[GitHub] [calcite] zabetak commented on a change in pull request #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #1636: [CALCITE-3568] BigQuery, Hive, Spark SQL dialects don't support nested aggregates
URL: https://github.com/apache/calcite/pull/1636#discussion_r354463606
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java
 ##########
 @@ -108,6 +108,10 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
             && !SqlTypeUtil.isNumeric(call.type);
   }
 
+  @Override public boolean supportsNestedAggregations() {
+    return false;
 
 Review comment:
   Thanks for verifying @amaliujia. One minor thing: for non specific code related things it is better to add comments in the JIRA case. It is better for people who are going to look into the case in the future and it also creates less notifications.   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services