[GitHub] [couchdb] nickva commented on a change in pull request #2426: Use separate requests to write design when replicating

[GitBox <gi...@apache.org>]

nickva commented on a change in pull request #2426: Use separate requests to write design when replicating
URL: https://github.com/apache/couchdb/pull/2426#discussion_r364466467
 
 

 ##########
 File path: src/couch_replicator/src/couch_replicator_worker.erl
 ##########
 @@ -269,16 +269,28 @@ fetch_doc(Source, {Id, Revs, PAs}, DocHandler, Acc) ->
     end.
 
 
-remote_doc_handler({ok, #doc{atts = []} = Doc}, {Parent, _} = Acc) ->
-    ok = gen_server:call(Parent, {batch_doc, Doc}, infinity),
-    {ok, Acc};
-remote_doc_handler({ok, Doc}, {Parent, Target} = Acc) ->
+remote_doc_handler({ok, #doc{id = <<?DESIGN_DOC_PREFIX, _/binary>>} = Doc},
+        Acc) ->
+    % Flush design docs in their own PUT requests to correctly process
+    % authorization failures for design doc updates.
+    couch_log:debug("Worker flushing design doc", []),
 
 Review comment:
   I had copied the pattern from the attachment flusher were it had a similar log line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services