[GitHub] [shiro] bmarwell commented on a diff in pull request #944: [#942] Fix flaky test; update snakeyaml for test app

["bmarwell (via GitHub)" <gi...@apache.org>]

bmarwell commented on code in PR #944:
URL: https://github.com/apache/shiro/pull/944#discussion_r1238162656


##########
integration-tests/jaxrs/app/pom.xml:
##########
@@ -46,10 +46,23 @@
             <artifactId>shiro-jaxrs</artifactId>
         </dependency>
 
+        <!-- needed by javafaker, override -->
+        <dependency>
+            <groupId>org.yaml</groupId>
+            <artifactId>snakeyaml</artifactId>
+            <version>2.0</version>
+        </dependency>
+
         <dependency>
             <groupId>com.github.javafaker</groupId>
             <artifactId>javafaker</artifactId>
             <version>1.0.2</version>
+            <exclusions>

Review Comment:
   Sadly yes, because v2 of snakeyaml doesn't have an android classifier, so it cannot be overridden anymore. v1.x is heavily outdated with existing CVEs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org