You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org> on 2010/01/26 19:27:55 UTC
[jira] Created: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
MECLIPSE-156 wasn't resolved
----------------------------
Key: MECLIPSE-636
URL: http://jira.codehaus.org/browse/MECLIPSE-636
Project: Maven 2.x Eclipse Plugin
Issue Type: Bug
Components: Core : Workspace settings
Affects Versions: 2.7
Reporter: Ramiro Pereira de Magalhães
Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=223750#action_223750 ]
Ramiro Pereira de Magalhães commented on MECLIPSE-636:
------------------------------------------------------
Hey, guys, I uploaded a patch that has a fix for this issue and the a test case that shows the problem is solved, but it has not been applied yet. Am I missing something? Is there anything else I can do to help you solve this issue?
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
> Attachments: MECLIPSE-636-withTests.patch, patch-MECLIPSE-636.patch
>
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MECLIPSE-636) MECLIPSE-156 wasn't
resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=208231#action_208231 ]
Ramiro Pereira de Magalhães edited comment on MECLIPSE-636 at 1/26/10 12:34 PM:
--------------------------------------------------------------------------------
Just to be a little more clear: I think that this patch http://jira.codehaus.org/secure/attachment/34526/MECLIPSE-156-maven-eclipse-plugin.patch wasn't applied but should have been.
I'd also like to comment that I did not find any documentation about that property.
was (Author: ramiromagalhaes):
Just to be a little more clear: I think that this patch http://jira.codehaus.org/secure/attachment/34526/MECLIPSE-156-maven-eclipse-plugin.patch wasn't applied but should have been.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MECLIPSE-636) MECLIPSE-156 wasn't
resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=219354#action_219354 ]
Ramiro Pereira de Magalhães edited comment on MECLIPSE-636 at 4/29/10 3:24 AM:
-------------------------------------------------------------------------------
Added a patch that solves this issue using patches and suggestions from MECLIPSE-156. Now, eclipse:eclipse uses the <encoding> text from the maven-compiler-plugin to set source code's and resources' encoding. It does not set the global encoding setting of an Eclipse project, so only the source and resource folders will have the encoding set. Also, fixed the eclipse:clean mojo, allowing it to properly exclude the .settings/org.eclipse.core.resources.prefs file which contains such preferences.
was (Author: ramiromagalhaes):
Added a patch that solves this issue using patches from MECLIPSE-156 and suggestions that came from this thread. Now, eclipse:eclipse uses the <encoding> text from the maven-compiler-plugin to set source code's and resources' encoding. It does not set the global encoding setting of an Eclipse project, so only the source and resource folders will have the encoding set. Also, fixed the eclipse:clean mojo, allowing it to properly exclude the .settings/org.eclipse.core.resources.prefs file which contains such preferences.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
> Attachments: patch-MECLIPSE-636.patch
>
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
Posted by "Diego Gomes (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=229671#action_229671 ]
Diego Gomes commented on MECLIPSE-636:
--------------------------------------
Hello, do we have any news about this issue? it's like a really important issue for people who use encoding.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
> Assignee: fabrizio giustina
> Attachments: MECLIPSE-636-withTests.patch, patch-MECLIPSE-636.patch
>
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MECLIPSE-636) MECLIPSE-156 wasn't
resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=208231#action_208231 ]
Ramiro Pereira de Magalhães edited comment on MECLIPSE-636 at 1/26/10 12:38 PM:
--------------------------------------------------------------------------------
Just to be a little more clear: I think that this patch http://jira.codehaus.org/secure/attachment/34526/MECLIPSE-156-maven-eclipse-plugin.patch wasn't applied but should have been.
I'd also like to add that I did not find any documentation about that property.
was (Author: ramiromagalhaes):
Just to be a little more clear: I think that this patch http://jira.codehaus.org/secure/attachment/34526/MECLIPSE-156-maven-eclipse-plugin.patch wasn't applied but should have been.
I'd also like to comment that I did not find any documentation about that property.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=208230#action_208230 ]
Ramiro Pereira de Magalhães commented on MECLIPSE-636:
------------------------------------------------------
A suggetion: I guess you should allow people to reopen issues.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
Posted by "Anthony O. (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=251800#action_251800 ]
Anthony O. commented on MECLIPSE-636:
-------------------------------------
I've seen a similar bug report here : https://issues.sonatype.org/browse/MNGECLIPSE-1782
I've used this workaround :
{noformat}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
<version>2.8</version>
<configuration>
<downloadSources>true</downloadSources>
<downloadJavadocs>true</downloadJavadocs>
<wtpmanifest>true</wtpmanifest>
<wtpapplicationxml>false</wtpapplicationxml>
<wtpversion>2.0</wtpversion>
<additionalConfig>
<file>
<name>.settings/org.eclipse.core.resources.prefs</name>
<content>
<![CDATA[eclipse.preferences.version=1
encoding/<project>=UTF-8]]>
</content>
</file>
</additionalConfig>
</configuration>
</plugin>
{noformat}
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
> Assignee: fabrizio giustina
> Attachments: MECLIPSE-636-withTests.patch, patch-MECLIPSE-636.patch
>
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramiro Pereira de Magalhães updated MECLIPSE-636:
-------------------------------------------------
Attachment: MECLIPSE-636-withTests.patch
I upload a new patch that fixes some small problems with the previous patch. This patch also includes a test case that ensures the correct preference file contains the needed configuration for a Eclipse's project source code and resource file encoding works properly.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
> Attachments: MECLIPSE-636-withTests.patch, patch-MECLIPSE-636.patch
>
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=208231#action_208231 ]
Ramiro Pereira de Magalhães commented on MECLIPSE-636:
------------------------------------------------------
Just to be a little more clear: I think that this patch http://jira.codehaus.org/secure/attachment/34526/MECLIPSE-156-maven-eclipse-plugin.patch wasn't applied but should have been.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-636) MECLIPSE-156 wasn't resolved
Posted by "Ramiro Pereira de Magalhães (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ramiro Pereira de Magalhães updated MECLIPSE-636:
-------------------------------------------------
Attachment: patch-MECLIPSE-636.patch
Added a patch that solves this issue using patches from MECLIPSE-156 and suggestions that came from this thread. Now, eclipse:eclipse uses the <encoding> text from the maven-compiler-plugin to set source code's and resources' encoding. It does not set the global encoding setting of an Eclipse project, so only the source and resource folders will have the encoding set. Also, fixed the eclipse:clean mojo, allowing it to properly exclude the .settings/org.eclipse.core.resources.prefs file which contains such preferences.
> MECLIPSE-156 wasn't resolved
> ----------------------------
>
> Key: MECLIPSE-636
> URL: http://jira.codehaus.org/browse/MECLIPSE-636
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: Core : Workspace settings
> Affects Versions: 2.7
> Reporter: Ramiro Pereira de Magalhães
> Attachments: patch-MECLIPSE-636.patch
>
>
> Task MECLIPSE-156 wasn't correctly implemented and the proposed feature (namely, that the plugin should support setting file encoding) does not work. I think that only one of the proposed patches there were implemented (on IdeUtils.java) while the other (on EclipseUtils.java) one wasn't.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira