You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/01/31 16:41:16 UTC
[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell opened a new
pull request #13: Rebase of PR #1 - Adding option to disable URL params check
jfmitchell opened a new pull request #13: Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13
All credit to @srgovindaraj for the changes.
I'm championing this PR - since it complements the ignoreUrlParams option in the dispatcher for highly cachable sites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert edited a comment
on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL
params check
Posted by GitBox <gi...@apache.org>.
rombert edited a comment on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-582642037
Thanks for picking this up @jfmitchell ! Some notes:
1. the build fails ( see Jenkins check ) - `[ERROR] org.apache.sling.dynamicinclude: Version increase required; detected 4.2.1, suggested 4.3.0`
1. the branch cannot be rebased due to conflicts; please squash all commits into one and then rebase
1. you can credit the original author, for instance by using `Originally-By: <email>` in the commit message
Otherwise changes LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue
#13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
Posted by GitBox <gi...@apache.org>.
rombert commented on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-587455117
Merged, thanks @jfmitchell !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue
#13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
Posted by GitBox <gi...@apache.org>.
rombert commented on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-582642037
Thanks for picking this up @jfmitchell ! Some notes:
# the build fails ( see Jenkins check ) - `[ERROR] org.apache.sling.dynamicinclude: Version increase required; detected 4.2.1, suggested 4.3.0`
# the branch cannot be rebased due to conflicts; please squash all commits into one and then rebase
# you can credit the original author, for instance by using `Originally-By: <email>` in the commit message
Otherwise changes LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert commented on issue
#13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
Posted by GitBox <gi...@apache.org>.
rombert commented on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-582643896
... and note that I merged the PR that removes the package exports, so you do not need to handle issue 1 from my comment above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell commented on
issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL
params check
Posted by GitBox <gi...@apache.org>.
jfmitchell commented on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-587424830
@rombert All done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell commented on
issue #13: Rebase of PR #1 - Adding option to disable URL params check
Posted by GitBox <gi...@apache.org>.
jfmitchell commented on issue #13: Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-580811242
#13 is the original PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] rombert merged pull
request #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL
params check
Posted by GitBox <gi...@apache.org>.
rombert merged pull request #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell edited a
comment on issue #13: Rebase of PR #13 - Adding option to disable URL
params check
Posted by GitBox <gi...@apache.org>.
jfmitchell edited a comment on issue #13: Rebase of PR #13 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-580811242
#1 is the original PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell removed a
comment on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to
disable URL params check
Posted by GitBox <gi...@apache.org>.
jfmitchell removed a comment on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-587390837
@rombert All done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-dynamic-include] jfmitchell commented on
issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL
params check
Posted by GitBox <gi...@apache.org>.
jfmitchell commented on issue #13: SLING-9045 - Rebase of PR #1 - Adding option to disable URL params check
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/13#issuecomment-587390837
@rombert All done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services