You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "Juice10 (GitHub)" <gi...@apache.org> on 2018/08/24 19:50:10 UTC
[GitHub] [incubator-openwhisk-devtools] Juice10 opened pull request
#151: Change config to work with 0.9.0
`CONFIG_whisk_loadbalancer_invokerBusyThreshold` has been replaced with `CONFIG_whisk_loadbalancer_invokerUserMemory`.
Before this fix the controller was triggering the following error:
```
[2018-08-24T19:26:24.437Z] [INFO] [#tid_sid_controller] [Controller] starting controller instance 0 [marker:controller_startup0_count:3021]
[2018-08-24T19:26:25.375Z] [INFO] [#tid_sid_dispatcher] [MessageFeed] handler capacity = 128, pipeline fill at = 128, pipeline depth = 256
Exception in thread "main" pureconfig.error.ConfigReaderException: Cannot convert configuration to a whisk.core.loadBalancer.ShardingContainerPoolBalancerConfig. Failures are:
at 'whisk.loadbalancer':
- Key not found: 'invoker-user-memory'.
at pureconfig.package$.getResultOrThrow(package.scala:138)
at pureconfig.package$.loadConfigOrThrow(package.scala:160)
at whisk.core.loadBalancer.ShardingContainerPoolBalancer.<init>(ShardingContainerPoolBalancer.scala:159)
at whisk.core.loadBalancer.ShardingContainerPoolBalancer$.instance(ShardingContainerPoolBalancer.scala:437)
at whisk.core.controller.Controller.<init>(Controller.scala:117)
at whisk.core.controller.Controller$.main(Controller.scala:258)
at whisk.core.controller.Controller.main(Controller.scala)
```
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] csantanapr commented on pull
request #151: Change config to work with 0.9.0
Posted by "csantanapr (GitHub)" <gi...@apache.org>.
Also add `CONFIG_whisk_containerPool_userMemory="1024 m"`
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] Juice10 commented on pull
request #151: Change config to work with 0.9.0
Posted by "Juice10 (GitHub)" <gi...@apache.org>.
Thanks Carlos, I was trying to find out what the other one was
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] ddragosd commented on issue
#151: Update for memory-based loadbalancing config change
Posted by "ddragosd (GitHub)" <gi...@apache.org>.
@csantanapr @dgrove-oss thanks for your reviews too !
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] csantanapr commented on pull
request #151: Change config to work with 0.9.0
Posted by "csantanapr (GitHub)" <gi...@apache.org>.
Might have problems with space but not sure if it needs to be "1024 m"
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] Juice10 commented on issue
#151: Change config to work with 0.9.0
Posted by "Juice10 (GitHub)" <gi...@apache.org>.
This doesn't get it to work for me locally (now I just suspect my computer is in desperate need of a reboot). Please don't merge this PR
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] ddragosd closed pull request
#151: Update for memory-based loadbalancing config change
Posted by "ddragosd (GitHub)" <gi...@apache.org>.
[ pull request closed by ddragosd ]
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] ddragosd commented on issue
#151: Update for memory-based loadbalancing config change
Posted by "ddragosd (GitHub)" <gi...@apache.org>.
@Juice10 thanks for the PR !
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] Juice10 commented on pull
request #151: Change config to work with 0.9.0
Posted by "Juice10 (GitHub)" <gi...@apache.org>.
The quotes make it worse actually. 1024m works for some of the instances. Locally I still have the invoker crashing though.
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] csantanapr commented on pull
request #151: Change config to work with 0.9.0
Posted by "csantanapr (GitHub)" <gi...@apache.org>.
No need to add this one, is redundant
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-openwhisk-devtools] Juice10 commented on issue
#151: Update for memory-based loadbalancing config change
Posted by "Juice10 (GitHub)" <gi...@apache.org>.
Ok this works for me locally now as well, the issue I was having didn't have anything to do with this. Please merge this pull request.
[ Full content available at: https://github.com/apache/incubator-openwhisk-devtools/pull/151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org